Revert "Fix media modal crash on WP 7.0 due to attachment filters wrapper change"#505
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #399.
That PR worked around a WP 7.0 change (core changeset 61757) that wrapped the media attachment filters in a container
<div>, which changed the return value oftoolbar.get( 'filters' )from theAttachmentFiltersview to a wrapperwp.media.Viewand crashedcustomizeFilters().This has since been fixed upstream: Trac #64948 reverted the shape change in the attachment filters return value and implemented the accessibility improvement via CSS-based positioning instead (changeset 62326 on trunk, merged to the 7.0 branch in 62327). WP 7.0 final therefore ships with the original
toolbar.get( 'filters' )behavior, making the subview-traversal workaround unnecessary complexity.This revert restores
customizeFilters()to its previous implementation, which works on both WP < 7.0 and WP 7.0+.Use of AI Tools
This PR was created with assistance from Claude Code (Anthropic).
🤖 Generated with Claude Code