-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Command Palette: Fix macOs label for sites unable to determine UA via PHP #11636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peterwilsoncc
wants to merge
19
commits into
WordPress:trunk
Choose a base branch
from
peterwilsoncc:fix/65121-command-pallete-shortcut-js-fallback
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−5
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
82ad508
Determine correct command palette label via JS.
peterwilsoncc 09b17fe
Slightly neater.
peterwilsoncc 321519a
Explain why wp-i18n is not used.
peterwilsoncc f7a5520
Revert "Slightly neater." because it breaks all things scope related.
peterwilsoncc aeca825
Apply suggestions from code review
peterwilsoncc 6c1658d
Shortcut as one word in all instances.
peterwilsoncc b599813
Relocate script before adding node.
peterwilsoncc d8172ee
MIsc changes.
peterwilsoncc 634d77a
Avoid concatination.
peterwilsoncc 42da05d
sites not users.
peterwilsoncc 7bd15d4
Update src/wp-includes/admin-bar.php
peterwilsoncc 895f727
Trolling?
peterwilsoncc 47cd7ef
Apply suggestion from @westonruter
peterwilsoncc dda24b6
Apply suggestion from @westonruter
peterwilsoncc 566148d
Easier to read, in my humble o
peterwilsoncc 1e06c9f
Only pass Apple OS shortcut label.
peterwilsoncc fa9e82c
Update src/wp-includes/admin-bar.php
peterwilsoncc 108271b
Update src/wp-includes/admin-bar.php
peterwilsoncc 14add38
Trolling?
peterwilsoncc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.