Administration: Display serialized option values read-only instead of a placeholder#11646
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @anatolinicolae! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
… a placeholder. Replaces the hard-coded "SERIALIZED DATA" placeholder in wp-admin/options.php and wp-admin/network/site-settings.php with the raw serialized value rendered read-only inside a collapsible <details>/<summary> element. The value remains non-editable and is excluded from form submission so it cannot be accidentally corrupted on save. Also tightens the surrounding template: * options.php: hoists $value initialization out of per-branch assignments, collapses the disabled-class logic into a ternary, merges the home/siteurl WP_HOME/WP_SITEURL checks. * site-settings.php: hoists the $ltr_fields list out of the per-row loop, consolidates four duplicated <tr> blocks into a single row with inline branches, and removes a double-escape on serialized-string values (esc_html() was applied at assignment and again at output via esc_textarea/esc_attr). Fixes #64581.
38f4d1d to
99e9156
Compare
Fixes https://core.trac.wordpress.org/ticket/64581
Summary
Replaces the hard-coded
SERIALIZED DATAplaceholder inwp-admin/options.phpandwp-admin/network/site-settings.phpwith the raw serialized value rendered read-only inside a native<details>/<summary>element. The value remains non-editable and is excluded from form submission, so it cannot be accidentally corrupted on save.This is an alternative implementation to #10853 based on the feedback left there:
<details>disclosure widget instead of a custom JS toggle.print_r(). Preserves the exact stored value so it can be safely copied / inspected without lossy reformatting.readonlytextarea +nameattribute omitted so the value cannot round-trip back into the database via the form.__( 'Serialized data' )replaces the hard-coded English placeholder.The same pattern is applied to the network site settings screen, which had the identical placeholder issue.
Incidental cleanup in the touched code
options.php: hoists$value = $option->option_valueout of per-branch assignments, collapses thedisabled-class logic into a ternary, merges thehome/siteurlWP_HOME/WP_SITEURLchecks.site-settings.php: hoists the\$ltr_fieldslist out of the per-row loop, consolidates four duplicated<tr>blocks into a single row with inline branches, and removes a double-escape on serialized-string values —esc_html()was applied at assignment and then again at output throughesc_textarea/esc_attr, corrupting any unserialized string containing<,>, or&.Test plan
/wp-admin/options.php. Any option whose value is a serialized array/object now renders as a▸ Serialized datatoggle; expanding it shows the rawa:N:{…}payload in a disabled textarea.$_POST).<,>,&) display correctly without double-escaping.home/siteurlrows whenWP_HOME/WP_SITEURLconstants are defined — they remain disabled inputs.