Skip to content

Administration: Fix misaligned spinner in admin screens #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-hamano wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Administration: Fix misaligned spinner in admin screens #11649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05a5254
Administration: Fix misaligned spinner in admin screens.
t-hamano Apr 27, 2026
75566da
Customize: Reset spinner top margin inside accordion triggers.
t-hamano Apr 27, 2026
560e225
Merge branch 'trunk' into 65131-spinner-position
t-hamano Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wp-admin/css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,6 @@ a#remove-post-thumbnail:hover,

#publishing-action .spinner {
float: none;
margin-top: 5px;
}

#misc-publishing-actions {
Expand Down Expand Up @@ -2460,7 +2459,7 @@ h1.nav-tab-wrapper, /* Back-compat for pre-4.4 */
filter: alpha(opacity=70);
width: 20px;
height: 20px;
margin: 4px 10px 0;
margin: 10px 10px 0;
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change changes the default top margin for all spinners, so we need to be aware. We need to verify in various places that this does not cause unintended shifts.

}

.spinner.is-active,
Expand All @@ -2480,6 +2479,7 @@ h1.nav-tab-wrapper, /* Back-compat for pre-4.4 */
}
#template .submit .spinner {
float: none;
vertical-align: top;
}

.metabox-holder .stuffbox > h3, /* Back-compat for pre-4.4 */
Expand Down
4 changes: 4 additions & 0 deletions src/wp-admin/css/customize-controls.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,10 @@ body.trashing #publish-settings {
display: block;
}

.accordion-section-title button.accordion-trigger .spinner {
margin-top: 0;
}
Comment on lines +575 to +577
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, the spinner position in Customizer > Menus > Accordion Title will be misaligned.

Image


@media (prefers-reduced-motion: reduce) {
#customize-theme-controls .accordion-section-title,
#customize-outer-theme-controls .accordion-section-title {
Expand Down
Loading