Skip to content

Permalinks: Ignore malformed post type query arrays#11651

Open
dhrupo wants to merge 2 commits intoWordPress:trunkfrom
dhrupo:ticket-65123-parse-request-post-type
Open

Permalinks: Ignore malformed post type query arrays#11651
dhrupo wants to merge 2 commits intoWordPress:trunkfrom
dhrupo:ticket-65123-parse-request-post-type

Conversation

@dhrupo
Copy link
Copy Markdown

@dhrupo dhrupo commented Apr 27, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/65123

Summary

This ignores non-scalar values when sanitizing post_type query vars in WP::parse_request(), preventing malformed array input from surfacing PHP warnings during front-end requests.

Testing Instructions

  1. Request /?post_type[][]=page&post_type[]=post on a local site with WP_DEBUG_DISPLAY enabled.
  2. Confirm no warning is emitted before the page output.
  3. Run npm run test:php -- --filter Tests_WP_ParseRequest.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dhrupo, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s use a single test with a data provider for better coverage, and we can remove the duplicate code.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 6b6be36. I collapsed the GET/POST cases into a single provider-backed test and removed the duplicated setup/cleanup code. I also reran npm run test:php -- --filter Tests_WP_ParseRequest and ./vendor/bin/phpcs --standard=phpcs.xml.dist tests/phpunit/tests/wp/parseRequest.php after the refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants