Skip to content

Embed: Update oEmbed regex for ReverbNation to support legacy subdomain - #13485

Open
yogeshbhutkar wants to merge 1 commit into
WordPress:trunkfrom
yogeshbhutkar:trac-66079/update-reverbnation-embed-endpoint
Open

Embed: Update oEmbed regex for ReverbNation to support legacy subdomain#13485
yogeshbhutkar wants to merge 1 commit into
WordPress:trunkfrom
yogeshbhutkar:trac-66079/update-reverbnation-embed-endpoint

Conversation

@yogeshbhutkar

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/66079

What, Why, and How?

ReverbNation moved their site and oEmbed API to legacy.reverbnation.com. The old www endpoint 404s and never redirects, so artist and song URLs stop embedding with the old URL. www pages still redirect to legacy, however, our matcher only allowed www, so a pasted legacy link never used the sanctioned provider. Legacy URLs didn't match the provider array, so they fell through to discovery via the page’s oEmbed <link> tags.

This PR updates the provider row: point the endpoint at legacy.reverbnation.com/oembed, and match both www and legacy so either hostname uses that API as a provider instead of discovery.

Screencast

screencast.mov

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-6 Astra
Used for: Validating the regex and running discovery on oEmbed endpoints for artists, songs, albums, and collections.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

* Adjusted the pattern to match both 'legacy' and 'www' subdomains for
improved compatibility with ReverbNation's oEmbed service.
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props yogeshbhutkar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant