Skip to content

Upgrade/Install: Use wp_print_inline_script_tag() in Bulk_Upgrader_Skin. #13492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haritpanchal wants to merge 1 commit into
base: trunk
Choose a base branch
from
+24 −4
Open

Upgrade/Install: Use wp_print_inline_script_tag() in Bulk_Upgrader_Skin. #13492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions src/wp-admin/includes/class-bulk-upgrader-skin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,12 @@ public function error( $errors ) {
}
$this->error = implode( ', ', $messages );
}
echo '<script>jQuery(\'.waiting-' . esc_js( $this->upgrader->update_current ) . '\').hide();</script>';
wp_print_inline_script_tag(
sprintf(
'jQuery( %s ).hide();',
wp_json_encode( '.waiting-' . $this->upgrader->update_current, JSON_HEX_TAG | JSON_UNESCAPED_SLASHES )
)
);
}

/**
Expand Down Expand Up @@ -172,7 +177,12 @@ public function bulk_footer() {
public function before( $title = '' ) {
$this->in_loop = true;
printf( '<h2>' . $this->upgrader->strings['skin_before_update_header'] . ' <span class="spinner waiting-' . $this->upgrader->update_current . '"></span></h2>', $title, $this->upgrader->update_current, $this->upgrader->update_count );
echo '<script>jQuery(\'.waiting-' . esc_js( $this->upgrader->update_current ) . '\').css("display", "inline-block");</script>';
wp_print_inline_script_tag(
sprintf(
'jQuery( %s ).css( "display", "inline-block" );',
wp_json_encode( '.waiting-' . $this->upgrader->update_current, JSON_HEX_TAG | JSON_UNESCAPED_SLASHES )
)
);
// This progress messages div gets moved via JavaScript when clicking on "More details.".
echo '<div class="update-messages hide-if-js" id="progress-' . esc_attr( $this->upgrader->update_current ) . '"><p>';
$this->flush_output();
Expand Down Expand Up @@ -200,7 +210,12 @@ public function after( $title = '' ) {
)
);

echo '<script>jQuery(\'#progress-' . esc_js( $this->upgrader->update_current ) . '\').show();</script>';
wp_print_inline_script_tag(
sprintf(
'jQuery( %s ).show();',
wp_json_encode( '#progress-' . $this->upgrader->update_current, JSON_HEX_TAG | JSON_UNESCAPED_SLASHES )
)
);
}
if ( $this->result && ! is_wp_error( $this->result ) ) {
if ( ! $this->error ) {
Expand All @@ -210,7 +225,12 @@ public function after( $title = '' ) {
'</p></div>';
}

echo '<script>jQuery(\'.waiting-' . esc_js( $this->upgrader->update_current ) . '\').hide();</script>';
wp_print_inline_script_tag(
sprintf(
'jQuery( %s ).hide();',
wp_json_encode( '.waiting-' . $this->upgrader->update_current, JSON_HEX_TAG | JSON_UNESCAPED_SLASHES )
)
);
}

$this->reset();
Expand Down
Loading