FED-4894 Support analyzer >=10 <15 - #1012
Merged
Merged
Conversation
greglittlefield-wf
force-pushed
the
allow-latest-analyzer
branch
from
August 6, 2026 23:37
1d7b385 to
344dd4c
Compare
…r analyzer 11-14
Analyzer 11-14 removed several AST APIs the builder relied on. This
migrates off them so the builder works across analyzer 10 through 14:
- NamedCompilationUnitMember → CompilationUnitMember (removed in 11)
- ClassDeclaration.{members,typeParameters,leftBracket,rightBracket} →
via .body.members/.namePart.typeParameters/etc. (removed in 11)
- ClassBody.members shim for analyzer 10/11 (moved to ClassBody in 12)
- NamedExpression → NamedArgument via dynamic dispatch (renamed in 13)
Also removes the build_runner <2.14.0 workaround cap (fixed in 2.15.1),
updates the validate_analyzer CI matrix to test ^10 through ^14, and
extends set_analyzer_constraint.dart to strip dev deps that cap the
analyzer so high-version rows can resolve.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
greglittlefield-wf
force-pushed
the
allow-latest-analyzer
branch
from
August 7, 2026 00:03
1bd7fab to
ef5b671
Compare
| /// Extension built on [NameHelper] to allow for easy access to the `name` | ||
| /// field of [Identifier]s. | ||
| extension TypeNameHelper on NamedType { | ||
| // Backwards compatibility for various analyzer versions that remove name/name2. |
Contributor
Author
There was a problem hiding this comment.
Removed these since they were only needed for older analyzer versions
| dynamic getJsChildren(instance) => getProperty(instance.props as Object, 'children'); | ||
|
|
||
| dynamic getRawDartChildren(var renderedInstance) { | ||
| dynamic getRawDartChildren(dynamic renderedInstance) { |
Contributor
Author
There was a problem hiding this comment.
This was a random compiler warning I fixed while I was debugging build_runner/test issues
Member
There was a problem hiding this comment.
yep, this is now an error to use var as a type in a declaration
danaoredson-wf
approved these changes
Sep 21, 2026
greglittlefield-wf
changed the title
greglittlefield-wf
marked this pull request as ready for review
September 21, 2026 23:50
| - id: link | ||
| name: Override over_react dependency with local path | ||
| run: cd ../.. && dart pub get && dart tool/travis_link_plugin_deps.dart | ||
| # TODO reinstate this once we update analyzer_plugin's analyzer range to overlap with what over_react supports |
Contributor
Author
There was a problem hiding this comment.
Note that analyzer_plugin isn't up to date on analyzer yet; that'll be a separate PR
| @@ -1,18 +1,18 @@ | |||
| name: over_react | |||
| version: 5.7.0 | |||
| version: 5.8.0 | |||
Member
There was a problem hiding this comment.
should this be bumped now or as part of the release?
Contributor
Author
There was a problem hiding this comment.
Oh good catch; usually it gets bumped in the release, but I don't think having it in this PR will cause any issues. If it does, I'll fix it up in the release PR
robbecker-wf
approved these changes
Sep 22, 2026
Member
|
QA +1 CI passes, builds and serves on analyzer 14 in internal projects |
btr-rmconsole-5
Bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Contributor
Author
|
@Workiva/release-management-p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The latest analyzer package version is 14.x, but the latest over_react supports is 10.x.
We want to support the latest, to unblock upgrading of other packages, and to allow consumers to use newer language features without risk of parsing errors.
Solution
>=5.13.0 <11.0.0to>=10.0.0 <15.0.0NamedCompilationUnitMemberremovals - changed toCompilationUnitMember, addedClassishDeclaration.nameto help with this and used it since we already had an instance of it in most placesBlockClassBodycasts when needednamedArgumentPartsto deal withArgumentListelement type changesanalyzerQA Instrucions
validate_analyzerCI run