Closed
Conversation
eschultink
commented
Sep 3, 2025
| } | ||
|
|
||
| public ProcessedContent decompressIfNeeded(ProcessedContent original) throws IOException { | ||
| if (Objects.equals(original.getContentType(), "application/gzip")) { |
Member
Author
There was a problem hiding this comment.
so this check covers the Slack Analytics API case, but only that.
my confusion is how we're handling gzip in other cases. best guess is there must be some other layer at which we're decompressing. Either we do it explicitly somewhere else, or Google HTTP client is automatically seeing the Content-Encoding header and dealing with it. A concern is be that if indeed Google HTTP client is decompressing gzip but not stripping the Content-Encoding header, we're going to double-decompress the content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip draft for sake of awareness.
provides little value except in NDJSON response cases, which to date are very few cases (slack analytics API, maybe glean audit log in future). in regular JSON cases, we're going to parse entire response into mem anyways.
Features
Change implications