Skip to content

Stream-based sanitizer interface#974

Closed
eschultink wants to merge 7 commits intorc-v0.6.0from
s207-stream-based-sanitization
Closed

Stream-based sanitizer interface#974
eschultink wants to merge 7 commits intorc-v0.6.0from
s207-stream-based-sanitization

Conversation

@eschultink
Copy link
Copy Markdown
Member

@eschultink eschultink commented Sep 3, 2025

wip draft for sake of awareness.

provides little value except in NDJSON response cases, which to date are very few cases (slack analytics API, maybe glean audit log in future). in regular JSON cases, we're going to parse entire response into mem anyways.

Features

  • work towards a fully Stream-based sanitizer interface; in theory, this will improve mem issues and avoid possible OOM in some cases.

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes? no
  • breaking changes? no

@eschultink eschultink self-assigned this Sep 3, 2025
}

public ProcessedContent decompressIfNeeded(ProcessedContent original) throws IOException {
if (Objects.equals(original.getContentType(), "application/gzip")) {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this check covers the Slack Analytics API case, but only that.

my confusion is how we're handling gzip in other cases. best guess is there must be some other layer at which we're decompressing. Either we do it explicitly somewhere else, or Google HTTP client is automatically seeing the Content-Encoding header and dealing with it. A concern is be that if indeed Google HTTP client is decompressing gzip but not stripping the Content-Encoding header, we're going to double-decompress the content

Base automatically changed from rc-v0.5.7 to main September 5, 2025 21:04
@eschultink eschultink changed the base branch from main to rc-v0.5.8 September 9, 2025 17:15
Base automatically changed from rc-v0.5.8 to main September 9, 2025 19:39
@eschultink eschultink changed the base branch from main to rc-v0.5.9 September 9, 2025 21:09
Base automatically changed from rc-v0.5.9 to main September 12, 2025 19:46
@eschultink eschultink changed the base branch from main to rc-v0.5.10 September 15, 2025 17:28
@eschultink eschultink deleted the branch rc-v0.6.0 October 2, 2025 16:04
@eschultink eschultink closed this Oct 2, 2025
@eschultink eschultink reopened this Oct 2, 2025
Base automatically changed from rc-v0.5.10 to main October 8, 2025 08:41
@eschultink eschultink changed the base branch from main to rc-v0.5.11 October 8, 2025 18:31
Base automatically changed from rc-v0.5.11 to main October 28, 2025 18:08
@eschultink eschultink changed the base branch from main to rc-v0.5.12 October 28, 2025 21:33
Base automatically changed from rc-v0.5.12 to main November 12, 2025 16:19
@eschultink eschultink changed the base branch from main to rc-v0.5.13 November 12, 2025 19:21
Base automatically changed from rc-v0.5.13 to main November 17, 2025 18:49
@eschultink eschultink changed the base branch from main to rc-v0.5.14 November 17, 2025 20:35
Base automatically changed from rc-v0.5.14 to main December 2, 2025 16:39
@eschultink eschultink changed the base branch from main to rc-v0.5.15 December 2, 2025 16:48
Base automatically changed from rc-v0.5.15 to main December 16, 2025 19:22
@eschultink eschultink changed the base branch from main to rc-v0.5.16 December 16, 2025 22:56
Base automatically changed from rc-v0.5.16 to main January 29, 2026 18:26
@eschultink eschultink changed the base branch from main to rc-v0.5.17 January 29, 2026 20:28
Base automatically changed from rc-v0.5.17 to main February 10, 2026 20:53
@eschultink eschultink changed the base branch from main to rc-v0.5.18 February 10, 2026 21:09
Base automatically changed from rc-v0.5.18 to main March 9, 2026 15:20
@eschultink eschultink changed the base branch from main to rc-v0.5.19 March 9, 2026 16:06
@eschultink eschultink deleted the branch rc-v0.6.0 April 6, 2026 18:01
@eschultink eschultink closed this Apr 6, 2026
@eschultink eschultink reopened this Apr 6, 2026
@eschultink eschultink changed the base branch from rc-v0.5.19 to rc-v0.6.0 April 6, 2026 18:06
@eschultink eschultink closed this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant