feat: helm chart for the server deployment - #7
Merged
Merged
Conversation
Replaces the kustomize base/overlays as the single deployment shape. Cluster-specific values (storage class, snapshot class, image tag, sentry env, replica count) are supplied by the deploying repository. Notable differences from the kustomize rendering, all intended: - wynnsource-config ConfigMap is rendered by the chart (config values moved out of the cluster repo); a checksum annotation now rolls the deployment on config changes - CNPG Cluster and Redis carry Prune=false,Delete=false so deleting the Application can never cascade into the data - dropped the dead explicit WCS_SENTRY_DSN env (key 'sentry-dsn' never existed in the secret; envFrom provides the real value) deploy/base and deploy/overlays stay untouched until the cluster repo has switched over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the chart migration plan (D1-A/D2-A/D3-A/D4-A):
deploy/chart/becomes the single deployment shape; cluster-specific values are supplied by k3s-gitops via ArgoCD multi-source$values.Intended deltas vs the kustomize rendering (validated by normalized
helm templatevskubectl kustomizediff — zero unexpected differences):wynnsource-configConfigMap rendered by the chart, with a checksum annotation that rolls the deployment on config changesargocd.argoproj.io/sync-options: Prune=false,Delete=false— deleting the Application can never cascade into dataWCS_SENTRY_DSNenv (keysentry-dsnnever existed in the secret;envFromprovides the real value)app: wynnsource-server(immutable on the live object)deploy/base+deploy/overlaysstay until k3s-gitops has switched both environments; a follow-up PR removes them.Companion PR against
dev.