Open
Conversation
- needed to add ER_TIP_F table to the test data (changed DCIR_bio to DCIR_all, a broader version of the original DCIR test table where biology and LPP (ER_TIP_F) were added.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
+ Coverage 93.50% 93.56% +0.06%
===========================================
Files 218 220 +2
Lines 2586 2596 +10
Branches 72 70 -2
===========================================
+ Hits 2418 2429 +11
+ Misses 168 167 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Changed DcirRowActExtractor to accept other event types than MedicalAct - Make DcirProductOrServiceExtractor extends DcirRowActExtractor
Contributor
Author
|
Hello @dsun0720 ! We needed to take into account these events for a study and thus implemented this new extractor. What do you think of this addition ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding logics for a new extractor / new event :
Some examples are , medical devices, prostheses, bandages, ...