fix(mcp): clean up subprocess listeners on OAuth browser open#1346
Open
walker83 wants to merge 1 commit into
Open
fix(mcp): clean up subprocess listeners on OAuth browser open#1346walker83 wants to merge 1 commit into
walker83 wants to merge 1 commit into
Conversation
Remove subprocess 'error' and 'exit' listeners after they fire, and on the success (timer) path. Previously all three paths left the listeners registered, leaking closures indefinitely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up
subprocess.on("error")andsubprocess.on("exit")listeners after they fire, and on the success path.Problem
When the 500ms timer fires (success path),
resume(Effect.void)is called but theerrorandexitlisteners on the subprocess are never removed. The closures captured by these listeners prevent GC of the subprocess object and surrounding scope.Fix
Extract a common
cleanup()helper that:subprocess.off()resume()This ensures all three paths (timer, error, exit) properly clean up.
Changes
packages/opencode/src/mcp/index.ts: add cleanup helper for subprocess listenersChecklist