fix(acp): clean up stdin listeners via ReadableStream cancel and named handlers#1348
Open
walker83 wants to merge 1 commit into
Open
fix(acp): clean up stdin listeners via ReadableStream cancel and named handlers#1348walker83 wants to merge 1 commit into
walker83 wants to merge 1 commit into
Conversation
…d handlers Two leak fixes: 1. ReadableStream stdin listeners in start(): extract named handlers and add cancel() to remove them via process.stdin.off(). 2. Promise stdin listeners (end/error): extract named handlers and call process.stdin.off() on both resolve and reject paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two groups of stdin listener leaks in the ACP command.
Leak 1: ReadableStream stdin listeners
The
start()callback registereddata,end, anderrorlisteners onprocess.stdinwith anonymous lambdas. No cleanup mechanism existed.cancel()method that callsprocess.stdin.off()for eachLeak 2: Await promise stdin listeners
process.stdin.on("end", resolve)andprocess.stdin.on("error", reject)were never cleaned up after resolve/reject.process.stdin.off()for the other listener before resolving/rejectingChanges
packages/opencode/src/cli/cmd/acp.tsChecklist