fix(models): export setInterval handle so it can be cancelled#1349
Open
walker83 wants to merge 1 commit into
Open
fix(models): export setInterval handle so it can be cancelled#1349walker83 wants to merge 1 commit into
walker83 wants to merge 1 commit into
Conversation
Store the models refresh interval ID in an exported module-level variable (modelsRefreshTimer) so it can be cleared if needed. Previously the setInterval handle was discarded, making it impossible to stop the refresh loop without killing the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store the models refresh interval timer ID in an exported variable so it can be cleared if needed.
Problem
setInterval(...).unref()was called without storing the handle. The timer ID was discarded, making it impossible to cancel the hourly refresh loop without killing the process. On module reload (HMR/development), a new interval is registered each time, accumulating timers.Fix
modelsRefreshTimervariablevoid refresh()directly instead ofasync () => { await refresh() })Changes
packages/opencode/src/provider/models.tsChecklist