Skip to content

Commenting out unused parameters #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvillarre merged 1 commit into from
Jun 5, 2026
Merged

Commenting out unused parameters #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions profile/plugin/device_offload/opencl/opencl_device_info_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ namespace xdp {
// when called and we don't want to actually do anything
}

void OpenCLDeviceInfoPlugin::writeAll(bool openNewFiles)
void OpenCLDeviceInfoPlugin::writeAll(bool /*openNewFiles*/)
{
// Intentionally left blank so we don't call the base class function
// when called and we don't want to actually do anything
Expand All @@ -101,14 +101,14 @@ namespace xdp {
// This function will only be called if an active device is going to
// be reprogrammed. We can assume the device is good before the call
// and bad after this call (until the next update device)
void OpenCLDeviceInfoPlugin::flushDevice(void* d)
void OpenCLDeviceInfoPlugin::flushDevice(void* /*d*/)
{
// Intentionally left blank so we don't call the base class function.
// This plugin no longer communicates with the actual device so
// there is no information to be flushed.
}

void OpenCLDeviceInfoPlugin::updateDevice(void* d, bool hw_context_flow)
void OpenCLDeviceInfoPlugin::updateDevice(void* d, bool /*hw_context_flow*/)
{
if (getFlowMode() == SW_EMU){
updateSWEmulationGuidance() ;
Expand Down Expand Up @@ -145,7 +145,7 @@ namespace xdp {
(db->getStaticInfo()).setDeviceName(deviceId, device->getName()) ;
}

void OpenCLDeviceInfoPlugin::updateOpenCLInfo(uint64_t deviceId)
void OpenCLDeviceInfoPlugin::updateOpenCLInfo(uint64_t /*deviceId*/)
{
// The argument list is now available due to the parsing of the
// SYSTEM_METADATA section, so we don't need to update it based off of
Expand Down
Loading