Fix for aie_status#87
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Reorders teardown in AIEStatusPlugin::endPollforDevice() to stop background polling threads before performing the final AIE status JSON write, preventing teardown hangs caused by concurrent AIE register/sysfs access on Edge platforms.
Changes:
- Move “last chance” status report write to occur after
endPoll()stops and joins background threads. - Add explanatory comments documenting the teardown hang scenario and rationale for ordering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+521
to
+526
| // Last chance at writing status reports | ||
| for (auto w : writers) { | ||
| mtxWriterThread.lock(); | ||
| w->write(false, handle); | ||
| mtxWriterThread.unlock(); | ||
| } |
Signed-off-by: predutta <predutta@amd.com>
Signed-off-by: predutta <predutta@amd.com>
jvillarre
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AIE Status teardown hang when used with AIE Profile on Edge
AIEStatusPlugin::endPollforDevice performed the final status JSON write before stopping its background polling threads (pollDeadlock and writeStatus). During hw context teardown, that left concurrent AIE register/sysfs access and could hang the process on exit (observed on VEK280 with both aie_profile and aie_status enabled). Reorder teardown to call endPoll() first, then perform the final write.