Made env example local-dev friendly#158
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the .env.example file by removing several LLM providers and monitoring configurations, focusing the setup on Google Gemini. It also introduces a new Authentication section for Google OAuth and JWT settings. Feedback includes correcting a likely typo in the Gemini model version, re-adding the ENVIRONMENT variable to ensure local development defaults, and maintaining consistent placeholder naming for authentication secrets.
|
|
||
| # Google Gemini | ||
| GEMINI_API_KEY=your_gemini_api_key_here | ||
| GEMINI_MODEL=gemini-2.5-flash |
There was a problem hiding this comment.
The model version gemini-2.5-flash appears to be a typo, as Gemini 2.5 is not a currently available version. For a working local setup, you should likely use gemini-1.5-flash or gemini-2.0-flash.
GEMINI_MODEL=gemini-1.5-flash
| # ============================================================================= | ||
| # Monitoring & Observability | ||
| # Authentication | ||
| # ============================================================================= |
There was a problem hiding this comment.
The ENVIRONMENT variable was removed in this PR. Since the default value in src/config/settings.py is production, local instances will default to production mode. To ensure a local-friendly setup (e.g., disabling production-only monitoring or analytics), it is better to explicitly set this to development.
# =============================================================================
# General Settings
# =============================================================================
ENVIRONMENT=development
# =============================================================================
# Authentication
# =============================================================================
| # ============================================================================= | ||
| ENVIRONMENT=production | ||
| GOOGLE_CLIENT_ID=your_google_client_id_here | ||
| GOOGLE_CLIENT_SECRET=your-google_client_secret_here |
There was a problem hiding this comment.
The placeholder for GOOGLE_CLIENT_SECRET uses a hyphen (your-google_client_secret_here), while GOOGLE_CLIENT_ID uses underscores. For consistency across the configuration file, it's recommended to use underscores for all placeholders.
GOOGLE_CLIENT_SECRET=your_google_client_secret_here
2 participants
Summary
This PR updates
.env.exampleso new contributors can set up the project locally without accidentally using production URLs or real-looking secrets.