Skip to content

Footer updated#569

Open
tanya-hubatenko wants to merge 1 commit into
mainfrom
footer-updated
Open

Footer updated#569
tanya-hubatenko wants to merge 1 commit into
mainfrom
footer-updated

Conversation

@tanya-hubatenko

Copy link
Copy Markdown
Contributor

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.
Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.
If the UI is being changed, please provide screenshots.

Checklist

  • I accept the contributor license agreement for this repository.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used (if not main).
  • A GitHub issue or linear task is linked to this pull request.

@tanya-hubatenko tanya-hubatenko requested a review from a team as a code owner June 9, 2026 19:15
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying website-storybook with  Cloudflare Pages  Cloudflare Pages

Latest commit: fcde7fd
Status: ✅  Deploy successful!
Preview URL: https://6cfad456.vue-3-components.pages.dev
Branch Preview URL: https://footer-updated.vue-3-components.pages.dev

View logs

Comment on lines +107 to +117
class="flex h-9 w-9 items-center justify-center rounded-md border border-white/20 text-white/60 hover:text-white"
>
<FontAwesomeIcon icon="fab fa-facebook-f" class="h-4 w-4" />
</a>
<a
href="https://www.tiktok.com/@yorksu"
target="_blank"
rel="noopener noreferrer"
class="flex h-9 w-9 items-center justify-center rounded-md border border-white/20 text-white/60 hover:text-white"
>
<FontAwesomeIcon icon="fab fa-tiktok" class="h-4 w-4" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The social media icons use the incorrect fab prefix instead of the project-standard fa-brands, which will likely cause them to fail to render.
Severity: MEDIUM

Suggested Fix

Replace the short-form fab prefix with the long-form fa-brands prefix for all social media icons in footer.ce.vue. For example, change "fab fa-instagram" to "fa-brands fa-instagram". This aligns the new component with the established project-wide convention for Font Awesome brand icons.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/components/Footer/footer.ce.vue#L93-L117

Potential issue: The social media icons in the footer use the short-form prefix `fab`
(e.g., `fab fa-instagram`), while the rest of the application consistently uses the
long-form `fa-brands` prefix. In the project's Font Awesome v7 configuration, icon
lookups are keyed by prefix. If the brand icons are registered under the `fa-brands`
prefix, using `fab` will result in a failed lookup, causing the social media icons in
the footer to not render.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant