Footer updated#569
Open
tanya-hubatenko wants to merge 1 commit into
Open
Conversation
Deploying website-storybook with
|
| Latest commit: |
fcde7fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6cfad456.vue-3-components.pages.dev |
| Branch Preview URL: | https://footer-updated.vue-3-components.pages.dev |
Comment on lines
+107
to
+117
| class="flex h-9 w-9 items-center justify-center rounded-md border border-white/20 text-white/60 hover:text-white" | ||
| > | ||
| <FontAwesomeIcon icon="fab fa-facebook-f" class="h-4 w-4" /> | ||
| </a> | ||
| <a | ||
| href="https://www.tiktok.com/@yorksu" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| class="flex h-9 w-9 items-center justify-center rounded-md border border-white/20 text-white/60 hover:text-white" | ||
| > | ||
| <FontAwesomeIcon icon="fab fa-tiktok" class="h-4 w-4" /> |
There was a problem hiding this comment.
Bug: The social media icons use the incorrect fab prefix instead of the project-standard fa-brands, which will likely cause them to fail to render.
Severity: MEDIUM
Suggested Fix
Replace the short-form fab prefix with the long-form fa-brands prefix for all social media icons in footer.ce.vue. For example, change "fab fa-instagram" to "fa-brands fa-instagram". This aligns the new component with the established project-wide convention for Font Awesome brand icons.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/components/Footer/footer.ce.vue#L93-L117
Potential issue: The social media icons in the footer use the short-form prefix `fab`
(e.g., `fab fa-instagram`), while the rest of the application consistently uses the
long-form `fa-brands` prefix. In the project's Font Awesome v7 configuration, icon
lookups are keyed by prefix. If the brand icons are registered under the `fa-brands`
prefix, using `fab` will result in a failed lookup, causing the social media icons in
the footer to not render.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
main).