Skip to content

Remove reference member from ChunkPointer #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YanzhaoW merged 1 commit into from
May 20, 2026
Merged

Remove reference member from ChunkPointer #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions source/centipede/reader/binary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ namespace centipede::reader
IterCursor iter;
IterEnd end;
EntryPoint<>* entrypoint;
std::size_t& current_size;
};

auto chunk_check_size_one(auto chunk_ptr)
Expand Down Expand Up @@ -106,7 +105,6 @@ namespace centipede::reader
{
chunk_ptr.entrypoint->add_local(local);
}
++(chunk_ptr.current_size);
return chunk_ptr;
}

Expand All @@ -124,7 +122,7 @@ namespace centipede::reader
return std::unexpected{ ErrorCode::reader_file_fail_to_read };
}
constexpr auto chunk_size{ 4 };
auto size = std::size_t{};
auto current_n_points = std::size_t{};
auto zipped = svs::zip(input.first, input.second) | svs::drop(1) |
svs::chunk_by([](const auto& current, const auto& next) -> auto
{ return std::get<0>(current) != 0U and std::get<0>(next) != 0U; });
Expand All @@ -140,12 +138,13 @@ namespace centipede::reader
svs::transform([](auto&& chunk) -> auto { return chunk | svs::values; });

auto is_ok = srs::all_of(svs::zip_transform(
[&size](auto&& chunk, auto&& entrypoint) -> bool
[&current_n_points](auto&& chunk, auto&& entrypoint) -> bool
{
auto chunk_ptr = ChunkPointer{ .iter = chunk.begin(),
.end = chunk.end(),
.entrypoint = &entrypoint,
.current_size = size };
auto chunk_ptr = ChunkPointer{
.iter = chunk.begin(),
.end = chunk.end(),
.entrypoint = &entrypoint,
};
using ChunkPtrType = decltype(chunk_ptr);
return chunk_check_size_one(chunk_ptr)
.transform(chunk_handle_measurement<ChunkPtrType>)
Expand All @@ -157,6 +156,12 @@ namespace centipede::reader
.and_then(chunk_not_end_and_increment<ChunkPtrType>)
.transform(chunk_handle_locals<ChunkPtrType>)
.and_then(chunk_end_after_increment<ChunkPtrType>)
.transform(
[&current_n_points](auto)
{
++current_n_points;
return true;
})
.has_value();
},
chunks,
Expand All @@ -166,7 +171,7 @@ namespace centipede::reader
{
return std::unexpected{ ErrorCode::reader_file_fail_to_read };
}
return size;
return current_n_points;
}
} // namespace

Expand Down
Loading