Repository navigation
Fix type error during OpenCV NMSBoxes results processing - #261
Conversation
Update `cv2.dnn.NMSBoxes` result iteration in `frigate.util.object.reduce_detections` to check if `index` is `isinstance(index, (int, np.integer))` rather than strictly `np.int32` to prevent `TypeError` exceptions during OpenCV execution in specific Numpy environments. Documented ad-hoc mock environment testing limitations for missing `peewee` and `cv2` module validations in `.zektopic/status.md` and `Jules/improvements.md`. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation noticeThe PR description could not be validated against the pull request template. Items to review:
Please consider updating your PR description to include all required sections from the template. |
Update `cv2.dnn.NMSBoxes` result iteration in `frigate.util.object.reduce_detections` to check if `index` is `isinstance(index, (int, np.integer))` rather than strictly `np.int32` to prevent `TypeError` exceptions during OpenCV execution in specific Numpy environments. Fixes mypy typing annotation for `List is invariant` when type hinting arguments. Documented ad-hoc mock environment testing limitations for missing `peewee` and `cv2` module validations in `.zektopic/status.md` and `Jules/improvements.md`. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Update `typing.Sequence` typing definition in `average_boxes` and `median_of_boxes` in `frigate.util.object.py` to correctly resolve `NameError: name 'typing' is not defined` inside of `generate_api_auth_spec.py` tests. Fixes MyPy typing issues on sequence parsing, and updates the PR with documentation on fallback testing runner limitations when executing tests without Docker. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Update `typing.Sequence` typing definition in `average_boxes` and `median_of_boxes` in `frigate.util.object.py` to correctly resolve `NameError: name 'typing' is not defined` inside of `generate_api_auth_spec.py` tests. Fixes MyPy typing issues on sequence parsing, and updates the PR with documentation on fallback testing runner limitations when executing tests without Docker. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Fixes a type error in
reduce_detectionswhen processing OpenCVNMSBoxesarray outputs that are not strictly cast tonp.int32. Adds documentation on remaining fallback testing runner limitations when executing tests without Docker.PR created automatically by Jules for task 11256660853995798820 started by @manupawickramasinghe