Conversation
In the New note form (note search, #826), typing a tag in the Tags field and reaching for Create with the mouse lost the click. Pressing the mouse on the button moved focus to it, the Tags field blurred and committed the typed word as a chip, the suggestion row under the fields unmounted, and the footer moved up before the mouse was released. No click fired. In the built app the button moved 44 px, the release landed on the backdrop, and the palette closed with the typed name and tag gone; with a taller list the release lands inside the card and a second click works, which is how it was noticed. The footer buttons and the "Open it" button no longer take focus on mousedown, the way the folder and tag rows under the fields already did not, so nothing moves until the click completes. `create()` was already counting text still typed in Tags, the way Enter does. Found during the phone pass on core 2.54.0; the phones get it with the shell releases that adopt this core. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0c45f-844c-77b8-846b-3e25b2447dab
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0c45f-844c-77b8-846b-3e25b2447dab
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZenNotes 2.54.1
One fix, no feature: a follow-up to #826 (the New note form that 2.54.0 added to note search), found the same day 2.54.0 shipped while the phone shells were being moved onto its core. Nothing else changed since 2.54.0.
Fixes
create()counts the text still typed in Tags the way Enter does.Verified before this PR
npx turbo run typecheck --force7 of 7, nothing from cache;npx turbo run test:run --force: shared-domain 1,685, app-core 2,646 (1 skipped), desktop 891 (4 skipped). The two newSearchPalette.test.tscases were red on 2.54.0 and are green here.npm run pack(runs the desktopbuild:prodfresh, then electron-builder); the packaged app launched with both stores isolated: CDP page target in 1.5 s, version 2.54.1.test:vim-editor,test:sidebar-vim,test:editor-improvements, all green with no renderer console errors.Docs: none needed; no user-facing behaviour is new, the form now does what 2.54.0 said it does.