Release 1.14.0 (build 28): the shared 2.56.1 core, and a vault's own name on the phone - #33
Merged
Merged
Conversation
The shared core moves from 2.55.0 to 2.56.1 (`core-2.56.1-core.hc872c08b6872aec4`, built from ZenNotes/zennotes `f8b24c09` with a clean tree: the desktop 2.56.0 release plus the one core fix the phones needed). What the phone gets from 2.56.0: a vault can go by a name of its own while its folder keeps its name (ZenNotes/zennotes#692; Rename Vault… in the command palette, reached from the ••• sheet's All commands…, or the Vault name field under Settings, Vault), a Markdown table converts into a database linked from the note (#832; Convert Table to Database… in the palette with the cursor in a table), Settings search reaches every setting and knows where new tasks go, a task added or moved from the calendar panel joins the note's Tasks section (#851), a task's code block stays under its text in Preview (#849), undo after the open note changed on disk (a sync, for one) starts a clean history instead of saving a mixed text (#852), and the in-app Help reads as one page. The template shortcuts (#847) are keyboard-only and do nothing here. What the shell had to do for #692. The core takes a vault's folder name from its root, and this shell's root is a label ("On My iPhone › ZenNotes › docs"), so without help the first settings save renamed the vault to the whole label; 2.56.1 lets a host name the folder itself, and `currentVaultInfo` now hands over `folderName`. The core only re-derives the name after a settings save, so `describeCurrentVault` resolves the display name from vault.json whenever a bridge method returns the open vault (desktop does the same in main). The Vaults sheet lists folders, and rename and delete act on the folder, so it now marks the open vault by the folder name the bridge holds (`currentVaultFolderName`) rather than by the shown name, which the display name had made a different string: before this, a renamed vault lost its check mark and its Delete and Rename guards. Each row shows the name the vault goes by (one vault.json read per local or iCloud folder; an evicted iCloud file keeps the folder name rather than waiting on a download), and the manage view names the folder beside a display name that differs. A test pins that a name written by the desktop survives a settings save from this device. Verified on the iPhone 17 Pro Max simulator with a throwaway XCUITest: a cleared name shows the folder, two settings saves (a favorite on and off) leave it, Rename Vault… through the palette shows the new name marked current with "(folder My Vault) … currently open" and Delete disabled, and clearing the name goes back to the folder. Adopted with `npm run core:adopt -- core-2.56.1-core.hc872c08b6872aec4 --source f8b24c09af1828b5242d572c7636df83236e2586`: every archive's SHA-256 and SHA-512 checked against its provenance, all three recording that source commit; the boundary check passed without an override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.14.0 (build 28): the shared ZenNotes core moves from 2.55.0 to 2.56.1 (
core-2.56.1-core.hc872c08b6872aec4, built from ZenNotes/zennotesf8b24c09with a clean tree: the desktop 2.56.0 release plus the one core fix the phones needed), adopted withnpm run core:adoptand verified against its provenance.On the phone: a vault can go by a name of its own while its folder keeps its name (ZenNotes/zennotes#692; Rename Vault… in the command palette, or the Vault name field under Settings → Vault). The core took the folder name from the vault's root, and this shell's root is a label ("On My iPhone › ZenNotes › docs"), so without help the first settings save renamed the vault to the whole label; core 2.56.1 lets a host name the folder itself,
currentVaultInfohands overfolderName,describeCurrentVaultresolves the display name from vault.json whenever a bridge method returns the open vault, and the Vaults sheet marks the open vault by its folder name (what rename and delete act on) while showing each vault by the name it goes by. Also from the core: a Markdown table converts into a database linked from the note (#832, Convert Table to Database… in the palette), Settings search reaches every setting and knows where new tasks go, a task added or moved from the calendar panel joins the note's Tasks section (#851), a task's code block stays under its text in Preview (#849), undo after the open note changed on disk starts a clean history instead of saving a mixed text (#852), and the in-app Help reads as one page. The template shortcuts (#847) are keyboard-only and do nothing here.Verified on the iPhone 17 Pro Max simulator: the two shipped UI test classes (DeepLink, Favorite) pass, and a throwaway XCUITest drove the vault-name round trip (a cleared name shows the folder, two settings saves leave it, a rename through the palette shows the new name marked current with the folder named beside it and Delete disabled, clearing goes back to the folder).
Two commits by the repo's convention: the adoption (with a test that a desktop-written name survives a settings save from this device), then
Version 1.14.0 (build 28)with only the Xcode project's twelve version sites. No native code changes.mainfast-forwards to the version commit, which is the commit to archive.