Conversation
There was a problem hiding this comment.
Nice work! 😎
I didn't find anything of concern
Did you know we can integrate this feedback directly into 50+ IDEs? Get setup in just one command
The pre-commit hook "check that scripts with shebangs are executable" was failing because the new clean.py, get_epoch.py, and get_platform.py scripts had shebangs but were not marked executable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
There were still some edge cases that didn't work on windows because they expected
shscripts or commands likewhich,rm, etc.Pull Request Checklist
Thank you for submitting a contribution!
Please address the following items: