-
Notifications
You must be signed in to change notification settings - Fork 233
Typedefs #5648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Typedefs #5648
Conversation
units/bomberassault.lua
Outdated
| manualfire_desc = [[Fire Special Weapon: Fire a cluster of temporary shield generators.]], | ||
| }, | ||
|
|
||
| selfDestructAs = [[ESTOR_BUILDING]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should become explodeAs rather than deleted. I applied that change directly to master though, thanks for noticing. dc91e3a
| @@ -0,0 +1,3 @@ | |||
| [submodule "recoil-lua-library"] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scary, do submodules with with stuff like rapid or infra steam depot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chaff file?
| return chunk, str2 | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random whitespace change in an otherwise untouched file, here and in unit_tech_k.lua
|
I am not sure about this. It needs a well written tutorial on the wiki for how to set it up. Also I am concerned that this will just bitrot. |
|
Now Im not sure about it as well... we can have typedefs files elsewhere (we can set .luarc.json), |
…X.SMOKE + SFX.EXPLODE)
Added typedefs file and .luarc.json for vscode Lua Language Server. Now Lua Language Server can find some actual bugs, and provides comments.