Open
Conversation
xt0fer
reviewed
Feb 15, 2018
xt0fer
left a comment
xt0fer
left a comment
There was a problem hiding this comment.
yes, adequate. but see my comment. rework at your discretion.
xt0fer
reviewed
Feb 15, 2018
|
|
||
| public double rateReturner (String requestedRate) { | ||
| String formattedInput = requestedRate.toLowerCase(); | ||
| if (formattedInput.equals("us dollar")) { |
There was a problem hiding this comment.
burying string literals inside the code makes it hard to use your class.
rework by changing all these to ENUMs and making the ENUM public, that way I might be able to use the class from other code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will add user input next
Maybe even some error handling idk lol