This repository was archived by the owner on Aug 13, 2026. It is now read-only.
UN-3987 [FIX] Send LLMWhisperer V2 params under the correct names - #205
Closed
chandrasekharan-zipstack wants to merge 2 commits into
Closed
UN-3987 [FIX] Send LLMWhisperer V2 params under the correct names#205chandrasekharan-zipstack wants to merge 2 commits into
chandrasekharan-zipstack wants to merge 2 commits into
Conversation
The adapter read the line splitter strategy under `line_spitter_strategy` while its JSON schema stores it as `line_splitter_strategy`, so the user's choice never applied. The same misspelling was also passed to the client, which forwarded a query param the service does not read. The page separator keeps its misspelled config key since existing adapter configs are stored under it, but is now sent under the client's corrected kwarg. Both need llmwhisperer-client 2.8.0 or newer. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dra3Xevzb5oYtMz9fhj8iG
Without it, usage reports record the service default for every Unstract-originated extraction, leaving no way to cross reference a row back to a document. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dra3Xevzb5oYtMz9fhj8iG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The LLMWhisperer V2 adapter's line splitter strategy setting has never been applied. Two breaks stacked:
line_splitter_strategy, butWhispererConfig.LINE_SPLITTER_STRATEGYwas"line_spitter_strategy", soconfig.get()never matched and theleft-prioritydefault was always used.whisper()kwarg, so the client sent query paramline_spitter_strategy, which the service does not read and Flask drops silently.Fixing either alone changes nothing.
Changes
LINE_SPLITTER_STRATEGYis now"line_splitter_strategy"— matches the schema key and the wire param.WhispererParamclass holds the two client kwargs whose names differ from the config key.page_seperatorstays as the config key (existing adapter configs in the DB are stored under it, no migration needed) but is now sent aspage_separator.file_nameis now sent, set to the basename of the file being extracted. Previously the adapter never sent it, so every Unstract-originated row in LLMWhisperer usage reports showed the service default. Separate commit if you'd rather drop it.llmwhisperer-clientpinned to>=2.8.0.Blocked on the client release
>=2.8.0does not exist yet — it is the release that carries Zipstack/llm-whisperer-python-client#34, which adds the correctly-namedline_splitter_strategy,page_separatorandfile_namekwargs. On an older client these kwargs raiseTypeError, so this must not merge before that release. Draft until then. On un-drafting: confirm the actual version number and regenerate the lockfiles.Ordering: unstract-llm-whisperer#721 (service accepts
page_separator) → llm-whisperer-python-client#34 release → this PR.Behaviour change to expect
The service validates the strategy and returns
400for anything outsideleft-priority/right-priority/mid-priority. Previously an out-of-range value was silently ignored, so a bad stored value becomes a hard error once the value actually arrives.Users who never touched the setting are unaffected — adapter, client and service all default to
left-priority.Verification
By inspection only. This repo has no pytest job in CI, so the regression test for the same logic lives in the monorepo's vendored copy (
unstract/sdk1/tests/test_llm_whisperer_v2_params.py) — 2 tests, both pass there.Not verified end to end: the extraction-output change needs the client release and a run against a deployed service.
Related: Zipstack/unstract#2236 — same fix in the vendored
unstract/sdk1copy.Jira: UN-3987, LW-406
🤖 Generated with Claude Code
https://claude.ai/code/session_01Dra3Xevzb5oYtMz9fhj8iG