Repository navigation
Conversation
Signed-off-by: Polina Cherkasova <polina.c@live.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for A2UI protocol version 1.0 across the a2ui_agent and a2ui_core packages, which includes updating catalog providers, capability negotiation, and adding a MessageProcessor.forAgent for outbound payload validation. Additionally, the handwritten Express parser has been replaced with an ANTLR-generated parser. The review feedback highlights several instances across multiple files where explicit type annotations on loop variables should be omitted to avoid triggering the omit_obvious_local_variable_types lint.
| throw A2uiCatalogError('No catalog states a protocol version.'); | ||
| } | ||
| final Set<A2uiProtocolVersion> versions = { | ||
| for (final CatalogApi catalog in catalogs) |
There was a problem hiding this comment.
Avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the omit_obvious_local_variable_types lint.
| for (final CatalogApi catalog in catalogs) | |
| for (final catalog in catalogs) |
References
- In Dart, avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the 'omit_obvious_local_variable_types' lint.
| ); | ||
| } | ||
| final A2uiProtocolVersion version = catalogsProtocolVersion([ | ||
| for (final CatalogConfig config in catalogs) config.catalog, |
There was a problem hiding this comment.
Avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the omit_obvious_local_variable_types lint.
| for (final CatalogConfig config in catalogs) config.catalog, | |
| for (final config in catalogs) config.catalog, |
References
- In Dart, avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the 'omit_obvious_local_variable_types' lint.
| }) => | ||
| MessageProcessor<T>( | ||
| catalogs: [ | ||
| for (final Catalog<T, FunctionApi> catalog in catalogs) |
There was a problem hiding this comment.
Avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the omit_obvious_local_variable_types lint.
| for (final Catalog<T, FunctionApi> catalog in catalogs) | |
| for (final catalog in catalogs) |
References
- In Dart, avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the 'omit_obvious_local_variable_types' lint.
| // The listener throws at the first error, so the tree is complete. | ||
| final ProgramContext program = parser.program(); | ||
| return [ | ||
| for (final StatementContext statement in program.statements()) |
There was a problem hiding this comment.
Avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the omit_obvious_local_variable_types lint.
for (final statement in program.statements())References
- In Dart, avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the 'omit_obvious_local_variable_types' lint.
| CallNode _call(String source, CallContext call) { | ||
| final args = <ExpressNode>[]; | ||
| final kwargs = <String, ExpressNode>{}; | ||
| for (final ArgContext arg in call.args()) { |
There was a problem hiding this comment.
Avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the omit_obvious_local_variable_types lint.
for (final arg in call.args()) {References
- In Dart, avoid adding an explicit type annotation to a loop variable when the iterable already has an explicit type argument, as this can trigger the 'omit_obvious_local_variable_types' lint.
1 participant
Follow up for flutter/genui#1058 (comment)