Repository navigation
feat(view-transitions): ✨ Implement view transitions for navigation and logo morphing - #862
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
…foreground color logic
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd94975521
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| return url.toString(); | ||
| }, | ||
| brandColor: "#5865F2", |
There was a problem hiding this comment.
Whenever Discord SSO is enabled, this value produces a prominent full-width purple button on the login and registration screens. That directly conflicts with the repository’s prohibition on prominent purple or violet UI; keep the Discord button neutral or use an allowed palette treatment instead.
AGENTS.md reference: AGENTS.md:L65-L70
Useful? React with 👍 / 👎.
| const BRAND_FILL = | ||
| "border-transparent bg-(--sso-brand) text-(--sso-brand-foreground) hover:bg-(--sso-brand) hover:brightness-90 dark:hover:brightness-110"; |
There was a problem hiding this comment.
For borderline brand colors, filtering the entire button changes both foreground and background and defeats the 4.5:1 contrast selection performed by ssoBrandForeground. For example, Discord’s white-on-#5865F2 contrast drops from about 4.61:1 to 4.38:1 with brightness-90 and 4.02:1 with the dark-mode brightness-110; use explicit hover background and foreground colors that retain sufficient contrast instead.
AGENTS.md reference: AGENTS.md:L70-L70
Useful? React with 👍 / 👎.
| setPendingId(providerId); | ||
| const result = await onSelectProvider(providerId); |
There was a problem hiding this comment.
If onSelectProvider rejects—such as when the existing SSO transport deliberately propagates malformed JSON from an otherwise successful response, or when a custom transport throws—execution leaves before pendingId is cleared. The selected button then remains loading and every other provider remains disabled, preventing a retry until the page is reloaded; handle the rejection and reset the state.
Useful? React with 👍 / 👎.
…s` for improved styling
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd6e20803b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return whiteTextContrast >= MIN_TEXT_CONTRAST || | ||
| whiteTextContrast >= darkTextContrast | ||
| ? LIGHT_FOREGROUND | ||
| : DARK_FOREGROUND; |
There was a problem hiding this comment.
For custom adapters using midpoint colors such as #777777, neither candidate reaches the documented 4.5:1 threshold: white is about 4.48:1 and #0a0a0a is about 4.42:1, but this branch still selects white because it merely has the better ratio. This makes the newly supported branded button fail normal-text contrast despite claiming to choose a readable foreground; use a darker foreground such as black or validate the selected candidate against the threshold.
AGENTS.md reference: AGENTS.md:L70-L70
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?