Merged
Conversation
Introduce cmdLogger interface and package-level log var in cmd/verbose.go that uses the SDK logger (common.GetLogger). All commands now emit verbose output when --verbose is passed: - update: current version, GitHub slug, latest release - version: Go version, OS/Arch - login: profile loading, authenticating - logout: keyring clearing - configure: profile/config saving - favorites: config loading, favorite count, saving Migrate 4 existing ad-hoc [verbose]/Warning messages in fetchStatusData, buildDirectoryNameMap, buildWorkspaceNameMap, and fetchEligibility to use log.Info(), removing the errWriter io.Writer parameter from these functions. Tests use spyLogger mock to verify log messages without SDK output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmdLoggerinterface and package-levellogvar incmd/verbose.gousing the SDK logger (common.GetLogger), ensuring consistentgrant | timestamp | INFO | messageformat across all commandsupdate,version,login,logout,configure, andfavorites(list/remove/non-interactive add)[verbose]/Warning:messages infetchStatusData,buildDirectoryNameMap,buildWorkspaceNameMap, andfetchEligibilitytolog.Info(), removing the now-unusederrWriter io.Writerparameter from these functionsTest plan
_VerboseLogstests verify expected log messages viaspyLoggermock_VerboseWarningtests updated to usespyLoggerinstead of checking stderr buffermake test)make lint)grant update -vshows verbose outputgrant version -vshows Go version and OS/Archgrant favorites list -vshows config loading