feat: add --output json global flag for machine-readable output#32
Closed
aaearon wants to merge 1 commit intofeat/tty-detectionfrom
Closed
feat: add --output json global flag for machine-readable output#32aaearon wants to merge 1 commit intofeat/tty-detectionfrom
aaearon wants to merge 1 commit intofeat/tty-detectionfrom
Conversation
Add persistent --output/-o flag (text/json) validated in PersistentPreRunE. JSON mode forces non-interactive by setting IsTerminalFunc to false. All commands now support JSON output: - Root elevation: cloudElevationOutput / groupElevationJSON - grant env: awsCredentialOutput - grant status: statusOutput with sessions array - grant revoke: []revocationOutput - grant favorites list: []favoriteOutput Add json struct tags to config.Favorite alongside yaml tags.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--output/-opersistent flag on root command acceptingtext(default) orjsonIsTerminalFuncto return falseenv,status,revoke,favorites listcmd/output.go(helpers),cmd/output_types.go(JSON structs)json:"..."struct tags toconfig.Favoritealongside existingyaml:"..."tagsMotivation
LLM agents and scripts need machine-readable output to parse elevation results, session lists, and credentials without scraping human-readable text.
Depends on
feat/tty-detection) — JSON mode relies on TTY detection to force non-interactive behaviorTest plan
TestIsJSONOutput— table test for format detectionTestWriteJSON— verifies valid indented JSON outputTestOutputFlagValidation— validates text/json accepted, xml rejectedTestRootElevate_JSONOutput— Azure cloud, AWS with credentials, group elevation JSONTestEnvCommand_JSONOutput— AWS credentials as JSONTestStatusCommand_JSONOutput— not authenticated and with sessionsTestRevokeCommand_JSONOutput— revocation results as JSON arrayTestFavoritesList_JSONOutput— cloud and group favorites as JSON arraymake test)make lint)