Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .abapgit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<MIN_RELEASE>750</MIN_RELEASE>
</item>
</REQUIREMENTS>
<VERSION_CONSTANT>ZCX_ERROR=&gt;C_VERSION</VERSION_CONSTANT>
<VERSION_CONSTANT>/APMG/CX_ERROR=&gt;C_VERSION</VERSION_CONSTANT>
</DATA>
</asx:values>
</asx:abap>
73 changes: 39 additions & 34 deletions abaplint.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@
"align_type_expressions": true,
"allowed_object_naming": true,
"allowed_object_types": {
"allowed": ["CLAS", "DEVC", "INTF"]
"allowed": [
"CLAS",
"DEVC",
"INTF",
"NSPC"
]
},
"ambiguous_statement": true,
"avoid_use": true,
Expand Down Expand Up @@ -159,41 +164,41 @@
"no_yoda_conditions": true,
"nrob_consistency": true,
"object_naming": {
"aqbg": "^ZABAPPM",
"aqqu": "^ZABAPPM",
"aqsg": "^ZABAPPM",
"auth": "^ZABAPPM",
"clas": "^ZC(L|X)\\_ERROR",
"cmod": "^ZABAPPM",
"doma": "^ZABAPPM",
"dtel": "^ZABAPPM",
"enho": "^ZABAPPM",
"enhs": "^ZABAPPM",
"enqu": "^EZABAPPM",
"form": "^ZABAPPM",
"fugr": "^ZABAPPM",
"idoc": "^ZABAPPM",
"aqbg": "^Z",
"aqqu": "^Z",
"aqsg": "^Z",
"auth": "^Z",
"clas": "^/APMG/C(L|X)_ERROR",
"cmod": "^Z",
"doma": "^Z",
"dtel": "^Z",
"enho": "^Z",
"enhs": "^Z",
"enqu": "^EZ",
"form": "^Z",
"fugr": "^Z",
"idoc": "^Z",
"ignoreNames": [],
"ignorePatterns": [],
"intf": "^ZIF\\_ERROR",
"msag": "^ZABAPPM",
"intf": "^/APMG/IF_ERROR",
"msag": "^Z",
"patternKind": "required",
"pinf": "^ZABAPPM",
"prog": "^ZABAPPM",
"sfpf": "^ZABAPPM",
"sfpi": "^ZABAPPM",
"shlp": "^ZABAPPM",
"ssfo": "^ZABAPPM",
"ssst": "^ZABAPPM",
"sucu": "^ZABAPPM",
"suso": "^ZABAPPM",
"sxci": "^ZABAPPM",
"tabl": "^ZABAPPM",
"tran": "^ZABAPPM",
"ttyp": "^ZABAPPM",
"wdya": "^ZABAPPM",
"wdyn": "^ZABAPPM",
"xslt": "^ZABAPPM"
"pinf": "^Z",
"prog": "^Z",
"sfpf": "^Z",
"sfpi": "^Z",
"shlp": "^Z",
"ssfo": "^Z",
"ssst": "^Z",
"sucu": "^Z",
"suso": "^Z",
"sxci": "^Z",
"tabl": "^Z",
"tran": "^Z",
"ttyp": "^Z",
"wdya": "^Z",
"wdyn": "^Z",
"xslt": "^Z"
},
"obsolete_statement": true,
"omit_parameter_name": true,
Expand Down Expand Up @@ -262,7 +267,7 @@
"xml_consistency": true
},
"syntax": {
"errorNamespace": "^(Z|Y|LCL_|TY_|LIF_)",
"errorNamespace": "^(/APMG/|LCL_|TY_|LIF_)",
"globalConstants": [],
"globalMacros": [],
"version": "v750"
Expand Down
16 changes: 16 additions & 0 deletions src/#apmg#.nspc.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="utf-8"?>
<abapGit version="v1.0.0" serializer="LCL_OBJECT_NSPC" serializer_version="v1.0.0">
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<NSPC>
<NAMESPACE>/APMG/</NAMESPACE>
<REPLICENSE>41813564412598342476</REPLICENSE>
</NSPC>
<NSPC_TEXT>
<SPRAS>E</SPRAS>
<DESCRIPTN>apm</DESCRIPTN>
<OWNER>apm.to Inc.</OWNER>
</NSPC_TEXT>
</asx:values>
</asx:abap>
</abapGit>
18 changes: 9 additions & 9 deletions src/zcx_error.clas.abap → src/#apmg#cx_error.clas.abap
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CLASS zcx_error DEFINITION
CLASS /apmg/cx_error DEFINITION
PUBLIC
INHERITING FROM cx_static_check
CREATE PUBLIC.
Expand Down Expand Up @@ -46,14 +46,14 @@ CLASS zcx_error DEFINITION
"! @parameter text | Text
"! @parameter previous | Previous exception
"! @parameter longtext | Longtext
"! @raising zcx_error | Exception
"! @raising /apmg/cx_error | Exception
CLASS-METHODS raise
IMPORTING
!text TYPE clike
!previous TYPE REF TO cx_root OPTIONAL
!longtext TYPE csequence OPTIONAL
RAISING
zcx_error.
/apmg/cx_error.

"! Raise exception with T100 message
"! <p>
Expand All @@ -67,7 +67,7 @@ CLASS zcx_error DEFINITION
"! @parameter msgv4 | Message variable 4
"! @parameter previous | Previous exception
"! @parameter longtext | Longtext
"! @raising zcx_error | Exception
"! @raising /apmg/cx_error | Exception
CLASS-METHODS raise_t100
IMPORTING
msgid TYPE symsgid DEFAULT sy-msgid
Expand All @@ -79,18 +79,18 @@ CLASS zcx_error DEFINITION
!previous TYPE REF TO cx_root OPTIONAL
!longtext TYPE csequence OPTIONAL
RAISING
zcx_error.
/apmg/cx_error.

"! Raise with text from previous exception
"! @parameter previous | Previous exception
"! @parameter longtext | Longtext
"! @raising zcx_error | Exception
"! @raising /apmg/cx_error | Exception
CLASS-METHODS raise_with_text
IMPORTING
!previous TYPE REF TO cx_root
!longtext TYPE csequence OPTIONAL
RAISING
zcx_error.
/apmg/cx_error.

METHODS get_source_position REDEFINITION.
METHODS if_message~get_longtext REDEFINITION.
Expand All @@ -110,7 +110,7 @@ ENDCLASS.



CLASS zcx_error IMPLEMENTATION.
CLASS /apmg/cx_error IMPLEMENTATION.


METHOD constructor ##ADT_SUPPRESS_GENERATION.
Expand Down Expand Up @@ -251,7 +251,7 @@ CLASS zcx_error IMPLEMENTATION.
attr4 = 'IF_T100_DYN_MSG~MSGV4' ).
ENDIF.

RAISE EXCEPTION TYPE zcx_error
RAISE EXCEPTION TYPE /apmg/cx_error
EXPORTING
textid = t100_key
msgv1 = msgv1
Expand Down
2 changes: 1 addition & 1 deletion src/zcx_error.clas.xml → src/#apmg#cx_error.clas.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<VSEOCLASS>
<CLSNAME>ZCX_ERROR</CLSNAME>
<CLSNAME>/APMG/CX_ERROR</CLSNAME>
<LANGU>E</LANGU>
<DESCRIPT>General Error</DESCRIPT>
<CATEGORY>40</CATEGORY>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CLASS zcx_error_prev DEFINITION
CLASS /apmg/cx_error_prev DEFINITION
PUBLIC
INHERITING FROM zcx_error_text
INHERITING FROM /apmg/cx_error_text
CREATE PUBLIC.

************************************************************************
Expand All @@ -22,7 +22,7 @@ ENDCLASS.



CLASS zcx_error_prev IMPLEMENTATION.
CLASS /apmg/cx_error_prev IMPLEMENTATION.


METHOD constructor ##ADT_SUPPRESS_GENERATION.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CLASS ltcx_error_prev DEFINITION FOR TESTING
CLASS ltcl_error_prev DEFINITION FOR TESTING
RISK LEVEL HARMLESS
DURATION SHORT FINAL.

Expand All @@ -7,18 +7,18 @@ CLASS ltcx_error_prev DEFINITION FOR TESTING

ENDCLASS.

CLASS ltcx_error_prev IMPLEMENTATION.
CLASS ltcl_error_prev IMPLEMENTATION.

METHOD test.

TRY.
TRY.
DATA(i) = 1 / 0.
DATA(i) = 1 / 0 ##NEEDED.
CATCH cx_root INTO DATA(previous).
RAISE EXCEPTION TYPE zcx_error_prev EXPORTING previous = previous.
RAISE EXCEPTION TYPE /apmg/cx_error_prev EXPORTING previous = previous.
ENDTRY.
cl_abap_unit_assert=>fail( ).
CATCH zcx_error INTO DATA(error).
CATCH /apmg/cx_error INTO DATA(error).
cl_abap_unit_assert=>assert_equals(
act = error->get_text( )
exp = 'Division by zero' ).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<VSEOCLASS>
<CLSNAME>ZCX_ERROR_PREV</CLSNAME>
<CLSNAME>/APMG/CX_ERROR_PREV</CLSNAME>
<LANGU>E</LANGU>
<DESCRIPT>Previous Error</DESCRIPT>
<CATEGORY>40</CATEGORY>
Expand All @@ -13,13 +13,6 @@
<UNICODE>X</UNICODE>
<WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>
</VSEOCLASS>
<DESCRIPTIONS>
<SEOCOMPOTX>
<CMPNAME>CONSTRUCTOR</CMPNAME>
<LANGU>E</LANGU>
<DESCRIPT>CONSTRUCTOR</DESCRIPT>
</SEOCOMPOTX>
</DESCRIPTIONS>
</asx:values>
</asx:abap>
</abapGit>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CLASS zcx_error_t100 DEFINITION
CLASS /apmg/cx_error_t100 DEFINITION
PUBLIC
INHERITING FROM zcx_error
INHERITING FROM /apmg/cx_error
CREATE PUBLIC.

************************************************************************
Expand Down Expand Up @@ -28,7 +28,7 @@ ENDCLASS.



CLASS zcx_error_t100 IMPLEMENTATION.
CLASS /apmg/cx_error_t100 IMPLEMENTATION.


METHOD constructor ##ADT_SUPPRESS_GENERATION.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CLASS ltcx_error_t100 DEFINITION FOR TESTING
CLASS ltcl_error_t100 DEFINITION FOR TESTING
RISK LEVEL HARMLESS
DURATION SHORT FINAL.

Expand All @@ -7,17 +7,16 @@ CLASS ltcx_error_t100 DEFINITION FOR TESTING

ENDCLASS.

CLASS ltcx_error_t100 IMPLEMENTATION.
CLASS ltcl_error_t100 IMPLEMENTATION.

METHOD test.

TRY.
MESSAGE i000(oo) WITH 'Hello,' 'World!'.
RAISE EXCEPTION TYPE zcx_error_t100.
cl_abap_unit_assert=>fail( ).
CATCH zcx_error INTO DATA(lx_error).
RAISE EXCEPTION TYPE /apmg/cx_error_t100.
CATCH /apmg/cx_error INTO DATA(error).
cl_abap_unit_assert=>assert_equals(
act = lx_error->get_text( )
act = error->get_text( )
exp = 'Hello, World!' ).
ENDTRY.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<VSEOCLASS>
<CLSNAME>ZCX_ERROR_T100</CLSNAME>
<CLSNAME>/APMG/CX_ERROR_T100</CLSNAME>
<LANGU>E</LANGU>
<DESCRIPT>Message Error</DESCRIPT>
<CATEGORY>40</CATEGORY>
Expand All @@ -13,13 +13,6 @@
<UNICODE>X</UNICODE>
<WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>
</VSEOCLASS>
<DESCRIPTIONS>
<SEOCOMPOTX>
<CMPNAME>CONSTRUCTOR</CMPNAME>
<LANGU>E</LANGU>
<DESCRIPT>CONSTRUCTOR</DESCRIPT>
</SEOCOMPOTX>
</DESCRIPTIONS>
</asx:values>
</asx:abap>
</abapGit>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
CLASS zcx_error_text DEFINITION
CLASS /apmg/cx_error_text DEFINITION
PUBLIC
INHERITING FROM zcx_error_t100
INHERITING FROM /apmg/cx_error_t100
CREATE PUBLIC.

************************************************************************
Expand All @@ -23,7 +23,7 @@ ENDCLASS.



CLASS zcx_error_text IMPLEMENTATION.
CLASS /apmg/cx_error_text IMPLEMENTATION.


METHOD constructor ##ADT_SUPPRESS_GENERATION.
Expand Down
24 changes: 24 additions & 0 deletions src/#apmg#cx_error_text.clas.testclasses.abap
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
CLASS ltcl_error_text DEFINITION FOR TESTING
RISK LEVEL HARMLESS
DURATION SHORT FINAL.

PRIVATE SECTION.
METHODS test FOR TESTING.

ENDCLASS.

CLASS ltcl_error_text IMPLEMENTATION.

METHOD test.

TRY.
RAISE EXCEPTION TYPE /apmg/cx_error_text EXPORTING text = 'Test'.
CATCH /apmg/cx_error INTO DATA(error).
cl_abap_unit_assert=>assert_equals(
act = error->get_text( )
exp = 'Test' ).
ENDTRY.

ENDMETHOD.

ENDCLASS.
Loading