C++ parser tests almost all pass#86
Open
cnewman wants to merge 17 commits intoabb-iss:srcml-updatefrom
Open
Conversation
…P have been removed. POS has had a tag added to its namespace; the position tag.
…ng some of the bad parts of the auto transformation I wrote to convert the unit tests (there're still more to remove) and a lot of changing things in the parser or in DSes the parser uses so that it expects the new version of srcML. Most CPP tests passing at this point.
This reverts commit 9336b09.
…r now and finish c#/java then come back
Contributor
|
IMO, we can break backwards compatibility if srcML does. If someone wants to use the OP/LIT namespaces they can use older versions of SrcML.NET. |
…ked at other tests yet.
… on the codeparser.cs tests still.
…t place. Added a note on the mapping tests updated other file-read tests to use lib.
Author
|
Currently 17 tests fail but they're mostly reading/writing srcML files using the old runner. Need to change the way it's reading in/generating srcml/then reading out files and things like that. The parser tests are working except for a handful-- 3 or 4? maybe 5. I went ahead and pushed this into the pull for now since next week is my last. Tomorrow I'll look over this to make sure everything is in order/make changes where needed. It's big enough that there might still be a bit of mess in places. |
Also, I apparently didn't commit the xsl script I used to test the xslt portion of the library so I had to recreate it.
…rator tests for the other srcml generator. Not sure if this should happen or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is a large chunk on its own, figured I'd submit for now.
Since the change was partially automated, some of the names aren't so great (as @patrickfrancis has pointed out). I can tackle this after the rest of it is done since I can pattern match variable names.
I wasn't sure what to do with OP/LIT since I think it was stated that backwards compatibility was wanted? So if that's the case, I can put OP back where it was but I think abstract code parser was pretty tightly coupled to it. So backwards compatibility might be weird to try and do.
I've also just noticed a stray comment I didn't remove:
//NOTE: When the declaration is using f = bla this won't work because there is no decl on the inside. Fix.
Java/C# are going okay; some of their issues were fixed as I fixed C++. Will push those as I complete them.