Skip to content

When non-url params don't match, don't send a 404 #55

Description

@mlms13

Right now when params don't match, we're falling through to the next route handler (and eventually sending a 404 if nothing "matches"). This is a reasonable thing to do for non-matching URL params (e.g. an Int :id when we're expecting a String).

However, it's arguably a bit strange to send a 404 when you POST some params in the body, but you're missing a required param. The route isn't actually 404, it's just a 400 bad request.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions