Repository navigation
feat: write each poster label in its paired M3 role, as Material Theme Builder does - #218
Merged
Merged
Conversation
…e Builder does `primary` reads in `on-primary`, `on-primary` in `primary`, the surface family in `on-surface`, `outline` in `surface`, `inverse-primary` in `on-surface`, `scrim` and `shadow` in plain white; tones 80 and up in black, the rest in white -- the way the official app's poster paints them, instead of white in `mix-blend-mode: difference`. The fixed accents, which that poster does not draw, follow the same pairing, as do the custom colors and the dropped roles. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The Tailwind story draws its custom-color tiles and tonal shades by hand, as literal utility classes, outside `Scheme` and `Shades` -- so the pairing did not reach them. Each tile now reads in its pair (`text-on-myCustomColor1`), and shades 50 to 200 (tones 95 to 80) in black, the rest in white. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
abernier
marked this pull request as ready for review
October 6, 2026 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Each label of the
Scheme/Shadesposter is now written in the M3 role it is paired with, the way the official Material Theme Builder poster paints them, instead of white inmix-blend-mode: difference:primaryreads inon-primary,on-primaryinprimary, and so on for every*/on-*and*-container/on-*-containerpair (primary, secondary, tertiary, error, custom colors);surface-dim...surface-container-highest,outline-variant) inon-surface;on-surfaceandoutlineinsurface;on-surface-variantinsurface-variant;inverse-surface/inverse-on-surfaceswapped,inverse-primaryinon-surface;scrimandshadow, black in both schemes, in plain white;The fixed accents, which the official poster does not draw, follow the same pairing (
primary-fixed*inon-primary-fixed,on-primary-fixed*inprimary-fixed), as do the dropped roles (background/on-background,surface-variantinon-surface-variant,surface-tintinon-primary).The Tailwind story's hand-written tiles follow suit:
text-on-myCustomColor1& co. for the custom colors, black on shades 50 to 200 (tones 95 to 80) and white below.In
twmode the ink stays avar(--md-sys-color-*): that mode is about thebg-*utilities resolving.How the pairing was read
The official app is a Flutter canvas, so its poster was pixel-sampled: tile backgrounds segmented, each label's glyph color matched hex-equal against the other tiles' backgrounds in the same scheme, on both the light and dark scheme and the six tonal palette rows.
Checks
pnpm run lgtmgreen (318 tests).colorequals its paired role's background, on light, dark, custom colors and tones.Pre-existing, out of scope: in the Tailwind story the
Secondarytile renders light (bg-secondarycollides with shadcn's theme).🤖 Generated with Claude Code