Fix NVHPC recipes on ARM (aarch64) - #3
Open
marcsrt wants to merge 4 commits into
Open
Conversation
Mistaken copy-pasted from the recipe for ROCm, where they are indeed needed
Doing so to make the recipe agnostic of x86 or aarch64. Can be improved but since those images are GPU focused, it shouldn't matter too much for now.
|
Some doc are missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
Following feedback from a user testing the NVHPC recipes on an ARM machine, it appears those didn't work on that architecture.
It is relevant to fix them due to ARM being the architecture of NVIDIA so-called Superchips (GH200, GB200, VR200...).
Therefore, I took care of removing the conflicting parts from the recipes.
Unfortunately, I lack the hardware to test myself properly, so I check what I could using ARM emulation.
I might need an extra iteration once I'm able to run an image on actual ARM hardware, but this MR fixes build at least.