Skip to content

errors: Broaden 40035 to any integration filter regex - #365

Open
SimonWoolf wants to merge 1 commit into
mainfrom
broaden-40035-filter-regex
Open

SimonWoolf wants to merge 1 commit into
mainfrom
broaden-40035-filter-regex

Conversation

@SimonWoolf

Copy link
Copy Markdown
Member

Error code 40035 was documented as being specific to an integration's messageFilter, but it applies to any user-supplied regex on an integration rule, such as a channelFilter. This widens the title and summary accordingly.

  • Title: "Integration message filter regex not RE2-compatible" → "Integration filter regex not RE2-compatible"
  • Summary now refers to "one of its filters, such as a channel filter or message filter" (33 words, within the 15–40 guideline)
  • protocol/errors.json regenerated; npm run validate:errors passes with no warnings for 40035

The identifier keeps its existing name (integration_message_filter_regex_not_re2_compatible), since it's a frozen contract that SDK constants generate from. That does leave the constant name narrower than the code's actual scope — shout if you'd rather churn it now than live with the mismatch.

Note that the channelFilter validation path currently raises 40000 rather than 40035, and validates with a plain JS RegExp rather than RE2; that's being addressed separately.

🤖 Generated with Claude Code

40035 is documented as being specific to an integration's message
filter, but it applies to any user-supplied regex on an integration,
such as a channelFilter. Widen the title and summary accordingly.

The identifier is a frozen contract, so it keeps its existing name.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@SimonWoolf
SimonWoolf requested a review from lmars September 17, 2026 13:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants