[DX-1371] New navigation polish and mobile fixes#3395
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
matt423
reviewed
Jun 4, 2026
Member
matt423
left a comment
matt423
left a comment
There was a problem hiding this comment.
Good improvements generally but still some issues.
Still a horizontal scroll on the products and two vertical scrollbars
There's multiple scroll bar when not really needed
Contributor
Author
matt423
approved these changes
Jun 5, 2026
Remove 12px of left padding from the product bar's inner container (px-5 to pl-2 pr-5) so the leading product tab's icon lines up with the header logo and page content gutter at 20px. DX-1371 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pin the main header nav links (Platform/Products/Examples) to h-9 and swap the product bar tabs from py-2 to h-9 so both rows are exactly 36px tall. Previously the header links were ~32px and the product tabs ~35.6px (padding + label3 line-height), so they didn't quite match. DX-1371 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The accordion content wrapper used p-1 with -m-1, cancelling out to a 0px gap. Reduce the negative margin to -m-0.5 so the padding nets a 2px gap, matching the design, while keeping enough padding to avoid clipping focus rings and hover backgrounds during the open/close animation. DX-1371 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bump the left sidebar section heading padding-bottom from pb-1.5 (6px) to pb-2 (8px) to match the design. DX-1371 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
When a page exposes a single SDK language there is nothing to choose between, so render a static, non-interactive element instead of a disabled dropdown. It keeps the same bordered styling (icon, label, version badge) but drops the Select wrapper and chevron. Applied to both the single-language selector and each Client/Agent dual-language dropdown. DX-1371 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pin the single-language selector trigger to a fixed 195px width with left-aligned content and the chevron pushed to the right edge (ml-auto), so switching languages no longer resizes the control or shifts the right sidebar. Match the loading skeleton width so there is no hydration jump. DX-1371 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The mobile burger menu reused the desktop components, so both the Platform and Products tabs rendered the active page's product nav, and tapping a product navigated to its homepage instead of revealing its TOC. - LeftSidebar takes an optional `product` override (omit = active page; a key forces that product; null shows the placeholder). - ProductBar gains a selection mode (onSelectProduct/selectedProduct): product items become selectors instead of navigation links. Desktop is unchanged. - Header wires the mobile tabs: Platform forces the platform TOC; the Products tab tracks a selected product (defaulting to the current non-platform product) and shows its TOC inline. The burger now opens on the tab matching the current page (product -> Products, examples -> Examples, else Platform), and the selection resets on navigation. DX-1371 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
m-hulbert
force-pushed
the
dx-1371-nav-fixes
branch
from
6bfd6b6 to
2db3a6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some small polishing to the new docs navigation, and fixes a bug with the mobile burger menu:
Checklist