Skip to content

Preserve case and quoted spaces in dependency requirements #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewithfourtix wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Preserve case and quoted spaces in dependency requirements #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d84d8f
Preserve case and quoted spaces in dependency requirements
codewithfourtix Sep 5, 2026
9a77593
Address review feedback and strengthen regression coverage
codewithfourtix Sep 5, 2026
f364869
Apply repository formatting to regression tests
codewithfourtix Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/python_inspector/dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def get_dependency(specifier) -> DependentPackage:
>>> dep = get_dependency("foo==1.2.3")
>>> assert dep.purl == "pkg:pypi/foo@1.2.3"
"""
specifier = specifier and "".join(specifier.lower().split())
specifier = specifier and specifier.strip()
assert specifier, f"specifier is required but empty:{specifier!r}"

requirement = Requirement(requirement_string=specifier)
Expand Down
17 changes: 17 additions & 0 deletions tests/test_requirement_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Copyright (c) nexB Inc. and others. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
# See https://github.com/aboutcode-org/python-inspector for support or download.

import pytest

from python_inspector.dependencies import get_dependency


@pytest.mark.parametrize(
"text",
['Demo==1.2; sys_platform == "Windows Server"', "Demo @ https://example.org/Release/Demo.whl"],
)
def test_dependency_preserves_requirement_text(text):
dependency = get_dependency(" " + text + " ")
assert dependency.extracted_requirement == text
assert dependency.purl.startswith("pkg:pypi/demo")
Loading