Skip to content

fix: Narrowed the fix after self-review: dropped a global lexer#5242

Open
singlaamitesh wants to merge 1 commit into
aboutcode-org:developfrom
singlaamitesh:fix/4229-scancode-toolkit-4229
Open

fix: Narrowed the fix after self-review: dropped a global lexer#5242
singlaamitesh wants to merge 1 commit into
aboutcode-org:developfrom
singlaamitesh:fix/4229-scancode-toolkit-4229

Conversation

@singlaamitesh

Copy link
Copy Markdown

Fixes #4229

Fixes #0000

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Narrowed the fix after self-review: dropped a global lexer PATTERNS rule that risked mislabeling unrelated dot-joined words (e.g. 'License.Txt') anywhere in scanned text as a proper NAME, and replaced it with tokenizer logic scoped strictly to right after an Author/Authors tag, splitting a glued 'Author:Frankie.Chu' and/or a dot-joined 'Frankie.Chu' name into separate tokens so the existing AUTH+NNP+NNP grammar rule detects it (now also fixes the space-separated 'Author: Frankie.Chu' variant with no extra risk); full 4731-test cluecode regression suite passes except 2 pre-existing unrelated failures.

How this was tested: X

Copilot AI review requested due to automatic review settings July 18, 2026 12:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Author not detected in C++ file

2 participants