fix: Narrowed the fix after self-review: dropped a global lexer#5242
Open
singlaamitesh wants to merge 1 commit into
Open
fix: Narrowed the fix after self-review: dropped a global lexer#5242singlaamitesh wants to merge 1 commit into
singlaamitesh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4229
Fixes #0000
Tasks
Run tests locally to check for errors.
Narrowed the fix after self-review: dropped a global lexer PATTERNS rule that risked mislabeling unrelated dot-joined words (e.g. 'License.Txt') anywhere in scanned text as a proper NAME, and replaced it with tokenizer logic scoped strictly to right after an Author/Authors tag, splitting a glued 'Author:Frankie.Chu' and/or a dot-joined 'Frankie.Chu' name into separate tokens so the existing AUTH+NNP+NNP grammar rule detects it (now also fixes the space-separated 'Author: Frankie.Chu' variant with no extra risk); full 4731-test cluecode regression suite passes except 2 pre-existing unrelated failures.
How this was tested:
X