Skip to content

Compact and reduce alerts so they don't dominate the diff #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abstrask merged 2 commits into from
Nov 3, 2025
Merged

Compact and reduce alerts so they don't dominate the diff #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb10267
Compact alerts by writing as one paragraph
abstrask Jan 31, 2025
384d97c
Only add capability notifications for `head`, remove line-break
abstrask Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions flux-helm-diff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ output_msg() {
# Message line(s)
for msg in "$@"; do
echo "> ${msg}"
echo '>'
done
echo
} >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -173,25 +172,27 @@ helm_template() {
# Check if chart is using .Capabilities.KubeVersion
grep -R --include='*.yaml' --include='*.yml' --include='*.tpl' ".Capabilities.KubeVersion" "${chart_temp_path}" > /dev/null && {
echo "${ref} uses \".Capabilities.KubeVersion\"" >&2
if [[ ${#kube_version} -eq 0 ]]; then
output_msg TIP "Chart in \`${ref}\` ref uses [\`.Capabilities.KubeVersion\`](https://helm.sh/docs/chart_template_guide/builtin_objects/) but is not specifying a Kubernetes version to simulate. Will use Helm's default Kubernetes version: \`${helm_default_kube_version}\`." \
"See [Simulating Capabilities](https://github.com/marketplace/actions/flux-helm-diff#simulating-capabilities) for details."
helm_kube_version=() # treat as array, to avoid adding single-quotes
else
output_msg TIP "Chart in \`${ref}\` ref uses [\`.Capabilities.KubeVersion\`](https://helm.sh/docs/chart_template_guide/builtin_objects/) and is simulating the following Kubernetes version: \`${kube_version}\`"
helm_kube_version=(--kube-version "${kube_version}") # treat as array, to avoid adding single-quotes
if [[ "${ref}" == "head" ]]; then
if [[ ${#kube_version} -eq 0 ]]; then
output_msg TIP "Chart in \`${ref}\` ref uses [\`.Capabilities.KubeVersion\`](https://helm.sh/docs/chart_template_guide/builtin_objects/) but is not specifying a Kubernetes version to simulate. Will use Helm's default Kubernetes version: \`${helm_default_kube_version}\`. See [Simulating Capabilities](https://github.com/marketplace/actions/flux-helm-diff#simulating-capabilities) for details."
helm_kube_version=() # treat as array, to avoid adding single-quotes
else
output_msg TIP "Chart in \`${ref}\` ref uses [\`.Capabilities.KubeVersion\`](https://helm.sh/docs/chart_template_guide/builtin_objects/) and is simulating the following Kubernetes version: \`${kube_version}\`"
helm_kube_version=(--kube-version "${kube_version}") # treat as array, to avoid adding single-quotes
fi
fi
}

# Check if chart is using .Capabilities.APIVersions
grep -R --include='*.yaml' --include='*.yml' --include='*.tpl' ".Capabilities.APIVersions" "${chart_temp_path}" > /dev/null && {
echo "${ref} uses \".Capabilities.APIVersions\"" >&2
if [[ ${#api_versions[@]} -eq 0 ]]; then
output_msg IMPORTANT "Chart in \`${ref}\` ref uses [\`.Capabilities.APIVersions\`](https://helm.sh/docs/chart_template_guide/builtin_objects/) but is not specifying any APIs to simulate. Only the built-in API versions are available for templating." \
"See [Simulating Capabilities](https://github.com/marketplace/actions/flux-helm-diff#simulating-capabilities) for details."
else
output_msg TIP "Chart in \`${ref}\` ref uses [\`.Capabilities.APIVersions\`](https://helm.sh/docs/chart_template_guide/builtin_objects/) and is simulating the following APIs, in addition to the built-in:" \
"$(printf "\`%s\`\n" "${api_versions[@]}")"
if [[ "${ref}" == "head" ]]; then
if [[ ${#api_versions[@]} -eq 0 ]]; then
output_msg IMPORTANT "Chart in \`${ref}\` ref uses [\`.Capabilities.APIVersions\`](https://helm.sh/docs/chart_template_guide/builtin_objects/) but is not specifying any APIs to simulate. Only the built-in API versions are available for templating. See [Simulating Capabilities](https://github.com/marketplace/actions/flux-helm-diff#simulating-capabilities) for details."
else
output_msg TIP "Chart in \`${ref}\` ref uses [\`.Capabilities.APIVersions\`](https://helm.sh/docs/chart_template_guide/builtin_objects/) and is simulating the following APIs, in addition to the built-in:" \
"$(printf "\`%s\`\n" "${api_versions[@]}")"
fi
fi
}

Expand Down