SDL: Use external midi sequencer software when arg with "-midicmd foo".#12
Open
Artanejp wants to merge 4 commits intoaburch:masterfrom
Open
SDL: Use external midi sequencer software when arg with "-midicmd foo".#12Artanejp wants to merge 4 commits intoaburch:masterfrom
Artanejp wants to merge 4 commits intoaburch:masterfrom
Conversation
Contributor
|
This Git repository is only a mirror, please send your patch to our forums. |
Merge remote-tracking branch 'upstream/master' into sdl-midi-use-timidity
ceeac
pushed a commit
to ceeac/simutrans
that referenced
this pull request
Jun 21, 2020
get up to date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure for SDL/SDL2 with SDL_Mixer, loading and playing midi file(s) are very slowly and eats a lot of CPU time.
Because Mix_LoadMUS() tries to decode full track of a MIDI file to raw PCM data as default (maybe with some distros), this spend a lot of time.
But, at SDL_Mixer, available to use external command as a MIDI (or some formats) decoder, i.e. timidity.
So, I add a feature using external midi sequencer when running with ARG "-midicmd foo" or setting a environment variable; SIMUTRANS_MIDI_CMD.