When using ccache, don't override the user's choice#18
Open
h3xx wants to merge 1 commit intoaburch:masterfrom
Open
When using ccache, don't override the user's choice#18h3xx wants to merge 1 commit intoaburch:masterfrom
h3xx wants to merge 1 commit intoaburch:masterfrom
Conversation
If a user sets CMAKE_C_COMPILER_LAUNCHER or CMAKE_CXX_COMPILER_LAUNCHER, don't override it; it could be wrong.
Contributor
|
CMAKE_C/CXX_COMPILER_LAUNCHER was added in CMake 3.17 while Simutrans supports a minimum CMake version of 3.16, so this approach will not work in all cases. Also, the preferred method to contribute is via the forum (https://forum.simutrans.com/index.php?board=33.0) as this repository is just a mirror. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user sets
CMAKE_C_COMPILER_LAUNCHERorCMAKE_CXX_COMPILER_LAUNCHER, don't override it or overstep it; it could be wrong.