fix: throw Error instead of raw array for TypeScript compilation failures#160
Open
nikhiltelkar2005-glitch wants to merge 1 commit into
Open
Conversation
…ures (accordproject#128) Signed-off-by: Nikhil Telkar <nikhiltelkar2005@gmail.com>
nikhiltelkar2005-glitch
force-pushed
the
fix/compiler-error-object
branch
from
73c846f to
be09472
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #128
Problem:
When a template formula contained invalid TypeScript,
TemplateMarkToJavaScriptCompiler.compile()threw a rawArray<CompilerError>. This meant that any caller catching this error received[object Object]without a.messageor a stack trace, making the rich error information collected by Twoslash inaccessible.Solution:
Wrapped the raw
errorsarray into a proper standard JavaScriptErrorobject. The new error message groups the compilation failures by theirnodeIdand maps out each individual issue with its corresponding line and column number, making the failures much easier for users to debug.