Skip to content

Comments

[DQT] Fix random scroll jump when deleting selected fields#10361

Open
arnav-makkar wants to merge 1 commit intoaces:mainfrom
arnav-makkar:fix/10122-random-scrolling
Open

[DQT] Fix random scroll jump when deleting selected fields#10361
arnav-makkar wants to merge 1 commit intoaces:mainfrom
arnav-makkar:fix/10122-random-scrolling

Conversation

@arnav-makkar
Copy link
Contributor

Brief summary of changes

Added e.stopPropagation() to the delete click handler.

Testing

Before:

Screen.Recording.2026-02-13.at.00.56.09.mov

After:

Screen.Recording.2026-02-13.at.01.02.41.mov

Link(s) to related issue(s)

@github-actions github-actions bot added the Module: dataquery PR or issue related to (new) dataquery module label Feb 12, 2026
@adamdaudrich
Copy link
Collaborator

LGTM

@arnav-makkar
Copy link
Contributor Author

Thank you @adamdaudrich

Could you please mark this PR as approved as well so that it can be merged.

Same for all these other PRs that you've already reviewed: #10300 #10304 #10305 #10307

@adamdaudrich adamdaudrich self-requested a review February 19, 2026 13:23
Copy link
Collaborator

@adamdaudrich adamdaudrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamdaudrich
Copy link
Collaborator

please assign me to review them

@arnav-makkar
Copy link
Contributor Author

I do not have write access so cannot do that.

@driusan Please confirm

@driusan
Copy link
Collaborator

driusan commented Feb 23, 2026

@arnav-makkar This PR is already assigned to him. I'm not sure what's being asked of me.

@arnav-makkar
Copy link
Contributor Author

arnav-makkar commented Feb 23, 2026

Hi @driusan, I just wanted to know why @adamdaudrich wasn't able to mark this as reviewed.

A few PRs (#10300 #10304 #10305 #10307 #10311) have already been manually checked, but they’re still showing as “Review Required.” I wanted to clarify if there’s something pending on my side or if it’s related to permissions/workflow.

Since these are all very minor changes, there’s absolutely no rush. I only wanted to understand how the review/approval process works in such cases.

Thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module: dataquery PR or issue related to (new) dataquery module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dataquery] random scrolling effect

3 participants