[candidate_parameters] Family tab rely on options from SQL instead of redefining them in JS#10510
Open
HachemJ wants to merge 4 commits into
Open
[candidate_parameters] Family tab rely on options from SQL instead of redefining them in JS#10510HachemJ wants to merge 4 commits into
HachemJ wants to merge 4 commits into
Conversation
ridz1208
requested changes
May 27, 2026
Comment on lines
+310
to
+322
| $db->pselect( | ||
| "SELECT DISTINCT Relationship_type, RelationshipLabel | ||
| FROM family | ||
| WHERE Relationship_type IS NOT NULL | ||
| ORDER BY RelationshipLabel", | ||
| [] | ||
| ) | ||
| ); | ||
|
|
||
| $relationshipOptions = []; | ||
| foreach ($relationshipList as $row) { | ||
| $relationshipOptions[$row['Relationship_type']] = $row['RelationshipLabel']; | ||
| } |
Collaborator
There was a problem hiding this comment.
instead of doing the pselect + a forloop. use the pselectWithIndexKey() dataabse class function
Author
There was a problem hiding this comment.
implemented change + adapted js, working as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Load relationship options dynamically from the database and remove hardcoded values from the frontend.
Testing instructions (if applicable)
Do not expect a successful submission if you try adding a full sibling/half sibling or first cousin between candidates. The functionality currently seems broken on main. #10511
Link(s) to related issue(s)