Skip to content

[candidate_parameters] Fixed broken Family Information tab (add, render and delete)#10514

Open
HachemJ wants to merge 3 commits into
aces:mainfrom
HachemJ:FixFamilyTabAddButton
Open

[candidate_parameters] Fixed broken Family Information tab (add, render and delete)#10514
HachemJ wants to merge 3 commits into
aces:mainfrom
HachemJ:FixFamilyTabAddButton

Conversation

@HachemJ
Copy link
Copy Markdown

@HachemJ HachemJ commented May 28, 2026

Brief summary of changes

Converted family members to an array using iterator_to_array. Also fixed field name mismatches (e.g. Candidate to CandidateID)

This PR fixes the rendering of family members, which were not displayed correctly due to the add functionality bug. It also fixes the add and delete family members functionalities.

Testing instructions

Currently (on main):

  1. Go to the Family Information tab. (The Candidate parameters module is reachable by going to access profile (candidate_list) --> click on a candidate --> click on candidate info)
  2. (Optional) In some cases the Family Information tab is unaccessible if the study configuration does not have it enabled (check config module). You can also enable it from going to Admin --> Configuration --> select useFamily --> Submit.
  3. For any given candidate, try adding a family member by selecting another candidate ID in the first dropdown, and a relationship type in the second dropdown. Click on the Add Button.
  4. You should see the following error.
Error shown adding a family member
  1. Switch to FixFamilyTabAddButton branch and Redo Step 1 & 2.

  2. You should now see existing family members (if there is any yet) on the Family Information Tab.

Untitled 6
  1. Adding and deleting family members should now be functional (e.g. image below shows page after adding a half sibling to that same candidate)
Untitled 7

Image below shows page after deleting the existing full sibling of that same candidate.

Untitled 8
  1. If these changes are reflected in the database, success.

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Module: candidate_parameters PR or issue related to candidate_parameters module labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: PHP PR or issue that update PHP code Module: candidate_parameters PR or issue related to candidate_parameters module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[candidate_parameters] Family tab add functionality appears to be broken

1 participant