Skip to content

[configuration] Translate configuration module (non-db translations only)#10877

Open
HachemJ wants to merge 5 commits into
aces:29.0-releasefrom
HachemJ:TranslateConfiguration
Open

[configuration] Translate configuration module (non-db translations only)#10877
HachemJ wants to merge 5 commits into
aces:29.0-releasefrom
HachemJ:TranslateConfiguration

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR translates the configuration module in French. It only includes non-db translations (hardcoded in js and php files).

Note: I used AI for translations but double-checked them as a fluent French speaker.

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: configuration PR or issue related to configuration module Multilingual Any tasks related to making LORIS multilingual labels Jul 12, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 12, 2026
Comment on lines 67 to 71
$this->tpl_data['useDoBOptions']
= [
'1' => 'Yes',
'0' => 'No',
];

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

I don't think that this is even used anywhere in the code. It can probably be removed/cleaned up.

@driusan

driusan commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

@HachemJ This PR has a conflict, fyi

@lapadulamichael

This comment was marked as outdated.

@lapadulamichael lapadulamichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change and ready to merge once conflicts resolved

items={trajectoryData.sourceField || []}
required={true}
btnLabel='Add Field'
btnLabel={t('Add Field', {ns: 'configuration'})}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
btnLabel={t('Add Field', {ns: 'configuration'})}
btnLabel={t('Add field', {ns: 'configuration'})}

Translation not working because of 'F'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: configuration PR or issue related to configuration module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants