fix(llm-access-codex): drop bool literal asserts to satisfy clippy --tests#6
Merged
Merged
Conversation
clippy::bool_assert_comparison fires on `assert_eq!(x, true/false)`; rewrite the three in request/mod.rs tests as `assert!(x)` / `assert!(!x)`. These are pre-existing test asserts from the original request.rs that only surfaced now: CI never ran clippy --tests on llm-access-codex until the affected-crate CI (PR #5) started linting changed crates with --tests. Verified: cargo clippy -p llm-access-codex --tests -- -D warnings is clean, and 79 codex + 256 llm-access tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request simplifies unit test assertions in llm-access-codex/src/request/mod.rs by replacing assert_eq! comparisons against boolean literals with more idiomatic assert! and assert!(!...) macros. There are no review comments, and the changes are clean and correct. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippyon master is red after PR #4. The failure isclippy::bool_assert_comparisonon three
assert_eq!(x, true/false)calls inllm-access-codex/src/request/mod.rstests:
These are pre-existing test asserts carried over verbatim from the original
request.rs. They only surfaced now because CI never ranclippy --testsonllm-access-codexuntil the affected-crate CI (PR #5) started linting changedcrates with
--tests.What changed
Three lines, behaviour-identical:
Verification
cargo clippy -p llm-access-codex --tests -- -D warnings— clean (this is theexact command the affected-crate CI runs for a codex-only change).