Add mTLS client certificate support for proxy authentication#4430
Open
dhawalseth wants to merge 5 commits into
Open
Add mTLS client certificate support for proxy authentication#4430dhawalseth wants to merge 5 commits into
dhawalseth wants to merge 5 commits into
Conversation
Add support for configuring TLS client certificates when connecting through proxies that require mTLS authentication. This is configured via environment variables: - HTTPS_PROXY_CLIENT_CERT: Path to client certificate file (PEM) - HTTPS_PROXY_CLIENT_KEY: Path to client private key file (PEM) - HTTPS_PROXY_CA_CERT: Path to CA certificate file (PEM) The HttpClientHandlerFactory loads these certificates and configures the HttpClientHandler to present them during TLS handshake. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 tasks
…sageHandler The runner's primary HTTP paths (VssConnection/RawConnection) create bare HttpClientHandler instances without loading client certificates. RunnerWebProxy reads HTTPS_PROXY_CLIENT_CERT/KEY env vars but only HttpClientHandlerFactory (secondary path) wires them into the handler. Changes: - VssHttpMessageHandler: add ConfigureClientCertificates callback, invoke it in ApplySettings after proxy is set - RawHttpMessageHandler: same callback pattern - VssUtil: set RawHttpMessageHandler.DefaultWebProxy (was missing), wire cert loading callback into both handlers This enables mTLS proxy authentication for all runner communication: job pickup, token refresh, broker connections, action downloads. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dhawalseth
force-pushed
the
feature/mtls-proxy-support
branch
from
74b6602 to
72b5069
Compare
The OAuth token HTTP client creates its own HttpClientHandler without loading client certificates. This breaks mTLS proxy auth for broker session creation (IssuedTokenProvider → RawHttpMessageHandler path). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dhawalseth
force-pushed
the
feature/mtls-proxy-support
branch
from
0a80b0c to
559c3a5
Compare
Configure HttpClientTransport with client certificates for BlobClient and AppendBlobClient to support mTLS proxy authentication when uploading logs/results to Azure blob storage. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for configuring TLS client certificates when connecting through proxies that require mTLS authentication.
HTTPS_PROXY_CLIENT_CERT: Path to client certificate file (PEM format)HTTPS_PROXY_CLIENT_KEY: Path to client private key file (PEM format)HTTPS_PROXY_CA_CERT: Path to CA certificate file (PEM format)RunnerWebProxyto read and expose these certificate pathsHttpClientHandlerFactoryto load X509 certificates and configureHttpClientHandler.ClientCertificatesHTTP Paths Covered
All HTTP client paths in the runner now support mTLS:
ConfigureClientCertificatescallback in VssUtil.csConfigureClientCertificatescallback in VssUtil.csConfigureClientCertificatescallbackwebProxy.HttpsProxyClientCert/KeyHttpClientTransportin ResultsHttpClient.csUse Case
Enterprise environments often use mTLS proxies (like Kraken, Envoy with mTLS, or corporate forward proxies) that require clients to present certificates for
authentication. This change enables the GitHub Actions runner to work in such environments.
Example Usage
Related PRs
This is part of a broader effort to add mTLS proxy support across the GitHub Actions ecosystem:
Test plan