Report exit code when a node action fails without reporting an error#4555
Open
marler8997 wants to merge 1 commit into
Open
Report exit code when a node action fails without reporting an error#4555marler8997 wants to merge 1 commit into
marler8997 wants to merge 1 commit into
Conversation
Report the exit code when a node or docker action exits non-zero but recorded no error of its own, instead of failing the step with an empty log. A crash, an OOM kill, or an external termination can end the process before it reports anything. Actions that already report their failure are left alone. ScriptHandler already does this for `run:` steps. This is the symptom in actions/cache#1754, where Windows runners die inside actions/cache with no output at all. The likely cause is the V8 Maglev crash worked around in actions#4447 (nodejs/node#62260), which kills node before any JavaScript runs. Reporting the exit code surfaces it as 0xC0000409. GetErrorCount() is compared before and after the run because embedded steps write to a collector shared with the enclosing context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the exit code when a node or docker action exits non-zero but recorded no error of its own, instead of failing the step with an empty log. A crash, an OOM kill, or an external termination can end the process before it reports anything. Actions that already report their failure are left alone. ScriptHandler already does this for
run:steps.This is the symptom in actions/cache#1754, where Windows runners die inside actions/cache with no output at all. The likely cause is the V8 Maglev crash worked around in #4447 (nodejs/node#62260), which kills node before any JavaScript runs. Reporting the exit code surfaces it as 0xC0000409.
GetErrorCount() is compared before and after the run because embedded steps write to a collector shared with the enclosing context.